Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Rockbox Ports are now being developed for various digital audio players!

+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  Cover in radio stations
« previous next »
  • Print
Pages: [1] 2

Author Topic: Cover in radio stations  (Read 4924 times)

Offline MadkaT

  • Member
  • *
  • Posts: 9
Cover in radio stations
« on: April 02, 2014, 11:36:34 AM »
Hello, I'm an old rockbox user and I wish if could be posible to use an artwork, cover, picture thing for the radio stations. Is a cosmetic detail, but It would be nice to put a cover art of the station, the name and the dial on the screen. Thanks.
Logged

Offline [Saint]

  • Rockbox Expert
  • Member
  • *
  • Posts: 1662
  • Hayden Pearce
    • Google+
Re: Cover in radio stations
« Reply #1 on: April 02, 2014, 03:59:37 PM »
This has been a possibility for years.


[Saint]
Logged
Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline cela

  • Member
  • *
  • Posts: 43
Re: Cover in radio stations
« Reply #2 on: April 02, 2014, 04:02:28 PM »
You can do this already. I have it on my Fuze+ its called "radio art"
It used to crash due to a bug, but I can confirm its now been fixed.

Just name put jpgs in a folder .rockbox\fmpresets and make then the same name as the station preset you want.

From Manual:-
Quote
It is also possible to show “Radio Art” which can be used to display images associated
with presets. The tags are exactly the same as for album art, described above. Images
need to be placed in/.rockbox/fmpresets/, and must have the same name as the
preset. They need to be in either.bmp or.jpgformat, and the radio must be in preset
mode and tuned to a preset (and not recording) in order for them to be shown

Logged
Rockboxed Daps:-
 Pinephone (RaaA), Benjie T6, Sony NWZ-E384 (good), Samsung YP-R0 (the best rockbox player), Creative Zen X -Fi, Sansa clip+, Sansa Fuze+ x2 (good for rockbox games) , Creative Zen X-Fi2 , Unbranded Rk27xx Dap (I need to fix the buttons)

Offline MadkaT

  • Member
  • *
  • Posts: 9
Re: Cover in radio stations
« Reply #3 on: April 02, 2014, 06:52:30 PM »
Wow nice, I have done the following:

1. I've made a preset file and loaded into the radio.
2. The radio is in preset mode.
3. This is an example of some presets:

94900000:Sample 1 radio
95900000:Sample 2 radio
96900000:Sample 3 radio

4. In the fmpresets folder I've added a file called 49400000.jpg then i turn the radio on, and preset the Sample 1 radio. But the cover doesn't show.

What I'm doing wrong?
Logged

Offline [Saint]

  • Rockbox Expert
  • Member
  • *
  • Posts: 1662
  • Hayden Pearce
    • Google+
Re: Cover in radio stations
« Reply #4 on: April 02, 2014, 09:45:35 PM »
Quote from: MadkaT on April 02, 2014, 06:52:30 PM
In the fmpresets folder I've added a file called 49400000.jpg then i turn the radio on, and preset the Sample 1 radio. But the cover doesn't show.

Unless your preset is actually called "49400000", this won't function as you expect.

Quote from: MadkaT on April 02, 2014, 06:52:30 PM
What I'm doing wrong?

Quote
Images need to be placed in/.rockbox/fmpresets/, and must have the same name as the preset.


[Saint]
Logged
Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline MadkaT

  • Member
  • *
  • Posts: 9
Re: Cover in radio stations
« Reply #5 on: April 03, 2014, 09:58:43 AM »
Sorry, the file name was a typo in my post, I have tested all the possibilities, but still can't work

This is my test

in the fmpresetsfile is

94900000:Sample 1 radio

I have 94900000.jpg and Sample 1 radio.jpg and two themes that support radio art (grayfog and googley-fuzeplus).

I've tested using letters for the preset names(A B C D E F. etc), and different files formats, jpg, and bmp.

94900000:A
94900001:B
94900002:C
94900003:D

Files:

A.jpg
B.jpg
C.jpg
D.jpg

Sorry about the stupid question but I still can't understand why is not working. Sorry :(

« Last Edit: April 03, 2014, 10:43:32 AM by MadkaT »
Logged

Offline cela

  • Member
  • *
  • Posts: 43
Re: Cover in radio stations
« Reply #6 on: April 03, 2014, 01:47:06 PM »
Quote
I have tested all the possibilities, but still can't work

What size is your radio art?
Mine are 96x96 and they work fine, but if they are too big it could be the problem.
Logged
Rockboxed Daps:-
 Pinephone (RaaA), Benjie T6, Sony NWZ-E384 (good), Samsung YP-R0 (the best rockbox player), Creative Zen X -Fi, Sansa clip+, Sansa Fuze+ x2 (good for rockbox games) , Creative Zen X-Fi2 , Unbranded Rk27xx Dap (I need to fix the buttons)

Offline MadkaT

  • Member
  • *
  • Posts: 9
Re: Cover in radio stations
« Reply #7 on: April 03, 2014, 07:36:57 PM »
I have tried various sizes

96x96
200x200
350x350 etc.

Also deleted other files and leaving one only with a letter number to the station, with the correct uppercase.

My image is JPG format 96x96 72 pixels per inch. I have scaled the image with GIMP

I also reinstalled my rockbox from the rockbox utility, but nothing happens.

A curious thing is when I use the grayscale theme and tune up the station with the cover, the storage activity turns on, but nothing happens :( in the other stations this won't happen. It probably tries to read the file.

Some ideas of what can I do to solve this? Thanks for the attention.
Logged

Offline Julian67

  • Member
  • *
  • Posts: 116
Re: Cover in radio stations
« Reply #8 on: April 03, 2014, 08:52:15 PM »
My experience with radio station cover art has been identical.  It does not work.  I never really cared enough to ask about it or report a bug but as someone else is experiencing the same issue and approaching the point of having a bloodied wall and painful forehead I thought I'd just add my experience:   quite often when it comes to actual_real_life_vs._how_the_manual_says_it_works people do keep quoting the manual despite not having the direct experience to be able to do other than than quote the manual.

Radio Station Cover Art, as described in the manual(s), does not work.  It doesn't work on iRiver H340 or H140 or Sansa Fuze+.  I guess maybe it works on a simulator or maybe it works on certain ancient builds from when the idea was implemented, but it does not work now.

My solution has always been to put the player in my pocket and listen without staring at the non-changing display, but then I am a lazy mf who is grateful when anything works at all.
Logged

Offline benshepherd

  • Member
  • *
  • Posts: 16
Re: Cover in radio stations
« Reply #9 on: April 04, 2014, 03:58:48 AM »
I have no direct experience of this, so consider this "just an idea" - but does the actual filesize of the image file have any bearing on the situation? My recollection is that the GIMP saves JPEGs at very high quality (i.e. a big file) by default; it might be worth trying to turn it down a bit and see if that helps.

Also, Julian67, your post really made me smile :)
Logged

Offline skip252

  • Member
  • *
  • Posts: 4
Re: Cover in radio stations
« Reply #10 on: April 04, 2014, 09:51:55 AM »
My experience with radio artwork is that it works in the way described in the manual. I have a Fuze+. Using the Rockbox Utility been it's updated to 8375b69-140403.  I have the Googley-FuzePlus-Storm theme loaded. When place a .jpg  with the same name as a FM preset in the .rockbox/fmpresets/ folder the images display.

I first used the Preset context menu to rename the presets. I find using the virtual keyboard awkward even with a custom keyboard. To make future changes easier I opened the saved .fmr file as a text file on my PC. I noted the changes saving the .fmr file had made and used the same pattern to make changes to my other presets. Once I did and added .jpg files named the same as the presets the radio artwork displays as expected.

The size of the artwork doesn't seem to matter as long as it's reasonable. I think of reasonable as no larger than the smallest dimension of the screen. Larger dimensions and file sizes work but I don't see a reason to eat up space using files that don't add to the display quality.

I'm not much of a radio listener but I find the ability to quickly identify which preset is active by the artwork displaying very helpful. I'd like to thank the people that did the coding and maker of the theme for their efforts in extending the capabilities of my Fuze+. 



 
« Last Edit: April 04, 2014, 05:17:09 PM by skip252 »
Logged

Offline Julian67

  • Member
  • *
  • Posts: 116
Re: Cover in radio stations
« Reply #11 on: April 04, 2014, 11:44:45 AM »
I had a look at various themes I've used.  Some don't include any fms file, some include one but the author didn't add the relevant section for displaying cover art, only a single specific backdrop.  Some themes didn't include a fully featured fms but have later been updated to do so.   It's not a consistent experience and I can see why it "just works" in some cases and appears to be broken in others.   If you have a theme with a well written fms it works just like in the manual and if you don't it doesn't.  So I copied a cover art section to the fms I'm using and indeed cover art did work after a reboot (full reboot, not just unmounting from USB) .

MadkaT I don't know what player or theme you are using but check the file .rockbox/wps/<your_theme>.fms and if it doesn't include a section like:

Code: [Select]
# Cover Artwork
%V(0,0,240,240,-)
%Cl(0,0,240,240,c,c)
%Cd

Then that is why you aren't seeing the covers.  Don't copy that example directly.  Look at your theme's .wps file and it probably has a suitable cover art section you can copy to the .fms file.  Possibly you need to edit it for width/height.  See the Rockbox manual if unsure how this works.
« Last Edit: April 04, 2014, 05:44:09 PM by Julian67 »
Logged

Offline [Saint]

  • Rockbox Expert
  • Member
  • *
  • Posts: 1662
  • Hayden Pearce
    • Google+
Re: Cover in radio stations
« Reply #12 on: April 04, 2014, 11:15:59 PM »
Well...that was an impressively quick change.

"It doesn't work, ever, insert rant and claims about people quoting from manuals yet not knowing what they're taking about here"
...
"Ohhhhh, the theme has to support it - well...carry on, nothing to see here".


[Saint]

Logged
Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline Julian67

  • Member
  • *
  • Posts: 116
Re: Cover in radio stations
« Reply #13 on: April 05, 2014, 05:58:37 PM »
Quote from: [Saint] on April 04, 2014, 11:15:59 PM
Well...that was an impressively quick change.

"It doesn't work, ever, insert rant and claims about people quoting from manuals yet not knowing what they're taking about here"
...
"Ohhhhh, the theme has to support it - well...carry on, nothing to see here".


[Saint]

It's nice to be appreciated, especially by the saintly.

There's more to it than "the theme has to support it" because themes can have bugs too.  Some themes don't work as described unless/until someone notices and fixes it (the big theme change a couple of years ago gave a lot of opportunities for this).  For example in the theme I use on the Fuze+ (grayfog) cover art in the radio screen had never worked despite it being supported (until yesterday when I saw this thread and was curious enough to revisit the issue and fix it).

Just now I checked the theme section of the site and in the theme description notice there is now an updated version, tagged "Fixed FM Radio artwork..."

It is perfectly possible to install bootloader, firmware and theme using the official installer onto fully working hardware, configure and use it exactly as described in the manual and for it to still not work in every aspect.  That has been precisely my experience on more than one theme and on more than one player, and the fact that the same feature didn't work on my two different colour screen players certainly gave a damn good impression of the feature not working.  Like I said earlier I didn't care enough about radio cover art to do any more than think "oh well" and carry on, but I do know how puzzling it can be if you're new to something, you follow the instructions to the letter,  it doesn't work yet everyone keeps telling you it does.

Anyone might hit upon a combination of hardware/firmware/config that does not do what it is supposed to do in every aspect.  The OP described the problem very clearly and posted his file names and presets demonstrating that he is apparently doing it by the book and it still doesn't work. Saying "sure it works" doesn't strike me as a diagnostic technique because it doesn't allow for the possibility of a bug being present.

Thank you for your blessings.

Logged

Offline [Saint]

  • Rockbox Expert
  • Member
  • *
  • Posts: 1662
  • Hayden Pearce
    • Google+
Re: Cover in radio stations
« Reply #14 on: April 05, 2014, 09:33:54 PM »
You just phrased "the theme has to support it" for me in a very long winded fashion.

"Not having user introduced bugs" is part of "supporting" this feature.

Users often forget that these themes are user submitted and no guarantee is given of their functionality. The theme site is perhaps a bit misleading, possibly adding to this confusion. We can't actually reliably say "Works with Current Build", as we have little idea of what "works" is, as intended by the author. "Works" is a pseudonym for "parses", really. We can tell the syntax is intact, no needless duplication of files is happening, and that no irrelevant files are included, but that's it. Being syntactically valid doesn't necessarily mean it functions as originally intended by the author.


[Saint]

Logged
Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

  • Print
Pages: [1] 2
« previous next »
+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  Cover in radio stations
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.105 seconds with 15 queries.