edit rockbox failsafe skin?

[edfardos]

Sansa Clip+

I like the Classic wps theme, which has no skin, so rockbox uses the rockbox_failsafe skin.

I like the rockbox_failsafe skin, which has no status bar at the top in the menu screen, and a nice simple status bar at the top of the playback screen.

Having said that, I'd like to make a minor change to the rockbox_failsafe status bar  (replace playlist counter with wall clock time).

there is no rockbox_failsafe.sbs I can edit (well there is, but it's empty).   If I load a skin, the status bar appears in the menu screens (which I don't want).

What am I missing?

thanks,
-edfardos

[edfardos]

Ah, the status bar is defined in the Classic.wps file.... got it.  thanks tho!

[JdGordon]

no, that isnt the inbuilt statusbar. I'm not sure what you want to do, but thefailsafe skins are alll hardcoded (the sbs one is autogenerated by code when required). The inbuilt statusbar is not skin code at all and is drawn when demanded (either globally or with the %wi tag (IIRC))

so either way you have to edit the code to do what you want.

[wodz]

Well, you don't have to edit source. You just need to create theme replicating hardcoded failsafe skin (and customize that)

[sd3]

so in order to modify the failsafe wps, which i really like, i would have to recreate it?
i can't just find the theme and build upon it, creating a new theme?

[yatto]

Well that was exactly what I wanted to do, me too.

If someone can find a way to re-create the failsafe WPS so that we can tweak it juste a little, that would be great ! I don't think I can do all the WPS by myself...

[bluebrother]

If someone can find a way to re-create the failsafe WPS

Just extract it from the source code ... it has to be written down somewhere so Rockbox can know about it, right?

http://git.rockbox.org/?p=rockbox.git;a=blob;f=apps/gui/wps.c;h=d1161ea71d4a4b8adae1e634fc77b50e22df5bfe;hb=HEAD#l88

[yatto]

That was clever. I didn't think I could possibly read the source code and find it, all these source code don't mean much to me.
But I found it !

Here is the content of the rockbox_failsafe WPS, ready to copy & paste in a .wps file:

Code: [Select]

%s%?it<%?in<%in. |>%it|%fn>
%s%?ia<%ia|%?d(2)<%d(2)|%(root%)>>
%s%?id<%id|%?d(1)<%d(1)|%(root%)>> %?iy<%(%iy%)|>

%al%pc/%pt%ar[%pp:%pe]
%fbkBit %?fv<avg|> %?iv<%(id3v%iv%)|%(no id3%)>
%pb
%pm

I was trying to make it from scratch, just with the appearance I saw and the simulator, that was my own one:

Code: [Select]

#activate the status bar (%wd to disable)
%we
#Track number. Track Title
%s%in. %it
#Artist
%s%ia
#Album   
%s%id %(%iy%)

#File Path
%s%fp
%pc/%pt%ar[%pp:%pe]
#%pb(x,y,[width],[height],image.bmp)
%pb
#Peak Meter - full line
%pm

#Next song
%s Next: %It - %Ia

As you can see, my WPS was much more simple, yet a little tweaked, and less efficient because it could not handle any exception. Nevertheless, for a first try in creating a WPS file, it was interesting, and maybe one day I will make my own super-cool WPS and - why not ? - a whole theme.
Yeah, since it was for me the very first time I designed a theme file, I felt like I HAD TO comment every single line, hehe ^^

Thanks for helping me to find this piece of code =)