patch to change the function of the power button?

[edfardos]

Personally, I'd like to have the power button just wake the lcd so I can see the time of day and play status of my clip+, exactly like the stock firmware.  It currently wakes the lcd, stops playback, then goes into some previous menu all with one click.   Is there a .cfg for the power button behavior?  Short of that, does anyone have a source code diff patch for this? Short of that, anyone know where button functions are implemented in the source?

Pressing the home button twice works most of the time, but I'd like to learn while I'm making rockbox perfect for my personal needs.

thanks!

Edfardos

[edfardos]

ah, it looks like it's in ./apps/keymaps/keymap-clip.c

static const struct button_mapping button_context_wps[]  = {
    { ACTION_WPS_PLAY,     BUTTON_UP|BUTTON_REL,        BUTTON_UP },
    { ACTION_WPS_STOP,     BUTTON_POWER|BUTTON_REL,     BUTTON_POWER },


Just remove BUTTON_POWER, and i should be good to go....

--edfardos

[gevaerts]

Have you looked at the "First Keypress Enables Backlight Only" setting?

[edfardos]

Yes, it's un predictable when in your pocket, or when you press a button 1ms after the screen goes dark.

I already modified the above source and it works great on the simulator, so I'm all good, just need to get the old ARM compiler for ubuntu 12.04...  something about rockboxdev.sh builds it?

thanks,

edfardos

[edfardos]

Compiled 3.13 with the changes, works perfectly on the device.  The power button simply wakes the screen now.

[saratoga]

I would probably have recommended using the current source, as 3.13 is a year old now, but at least you got it.

[edfardos]

Yah I considered that but isnt 3.13 more stable?   When I embark on 30 hors of airplanes I want that piece of mind.  Or is the master git branch considered stable by most people?    I kinda miss the debug menu and the volume limit found in the master branch.

[toehser]

3.13 is NOT more stable for some values of "stable".

It is a semantic thing... 3.13 is a known thing that isn't changing, while daily builds, by definition, change every day-

But 3.13 has known bugs that cause known crashes that have been fixed.

So if by "stable" you mean "crashes less", certain daily builds are MORE stable.

What is hard is that WHICH daily builds are "stable" and which ones have "other bugs in progress" is not defined.

I'm running a build from tips of git a week or two ago and it is DEFINITELY better than 3.13.