Loss of Max files in dir browser setting?

[chrisjj]

I cannot find the "Max files in dir browser" setting:

http://download.rockbox.org/release/3.13/rockbox-sansafuze-3.13.pdf


at the location given:



or anywhere else.

Any ideas?

EDIT: from Sansa Fuze+ to Sansa Fuze.
EDIT: reported as bug at http://www.rockbox.org/tracker/task/12948 .

[saratoga]

Looks like its actually the Max Entries in File Browser in english.lang.  Probably whoever wrote the manual section didn't use the English language file name, but translated it from whatever they used. 

[chrisjj]

Looks like its actually the Max Entries in File Browser

Thanks for the suggestion, but no it's not. The Database can show lists with many more tracks than the Max Entries in File Browser value.

[gevaerts]

Looks like its actually the Max Entries in File Browser

Thanks for the suggestion, but no it's not.

It is.

[chrisjj]

I'd be interested to see the evidence for that. Because, as I said, Max Entries in File Browser does not operate in accord with the description of Max Files in Dir Browser.

[gevaerts]

5917e8

[chrisjj]

5917e8

Is that a commit ID? It is not found in git: http://git.rockbox.org/?p=rockbox.git&a=search&h=HEAD&st=commit&s=5917e8

[bluebrother]

Is that a commit ID? It is not found in git: http://git.rockbox.org/?p=rockbox.git&a=search&h=HEAD&st=commit&s=5917e8

Works fine for me: http://git.rockbox.org/?p=rockbox.git;a=commit;h=5917e8

[gevaerts]

Sorry, I gave the wrong id (I had been looking up earlier history of the entire thing, and copied the wrong one from my commandline). 1b53f4 is the one you want.

[chrisjj]

Sorry, I gave the wrong id (I had been looking up earlier history of the entire thing, and copied the wrong one from my commandline). 1b53f4 is the one you want.

Thanks. You had me puzzled

http://git.rockbox.org/?p=rockbox.git;a=commit;h=1b53f4 says

Apply FS#8538 - iconsistencies in menu wording/capitalization as well as update Danish language.

referencing this saying

Code: [Select]

[id: LANG_MAX_FILES_IN_DIR]
   <source>
-    *: "Max Files in Dir Browser"
+    *: "Max Entries in File Browser"
   </source>
   <dest>
-    *: "Max Files in Dir Browser"
+    *: "Max Entries in File Browser"
   </dest>
So yes now I agree with Saratoga that the manual's "Max files in dir browser" is likely a reference to id: LANG_MAX_FILES_IN_DIR reworded as gaeverts says to "Max Entries in File Browser" without manual update. EDIT: that's the only 1b53f4 string change I see that definitely needed a manual update.

However, this doesn't change the fact that the setting with given behaviour in the manual doesn't exist:

Note: You may need to increase the value of the Max files in dir browser setting (Settings → General Settings → System → Limits) in order to view long lists of tracks in the ID3 database browser.

Unless anyone knows otherwise...

[gevaerts]

Note: You may need to increase the value of the Max files in dir browser setting (Settings → General Settings → System → Limits) in order to view long lists of tracks in the ID3 database browser.

Unless anyone knows otherwise...

The code seems to indicate that the limit in the settings is multiplied with an assumed average filename length (which is 40) in order to allocate a buffer. After that, the buffer size forms the actual limit, so if your filenames (or track titles, using the database) are shorter than 40 characters on average, more will fit.

That's from a very brief look at the code though, so I could be wrong.

Anyway, I will update the manual to reflect the changed string soon.,

[chrisjj]

The code seems to indicate that the limit in the settings is multiplied with an assumed average filename length (which is 40) in order to allocate a buffer. After that, the buffer size forms the actual limit, so if your filenames (or track titles, using the database) are shorter than 40 characters on average, more will fit.

Well, that doesn't accord with what I see. With Max Entries in File Browser = 50 (allowing 40 x 50 = 800 chars), with filenames totalling 38433 chars, Database browser Track shows all 1,234 files fine.

Whereas the File browser says "Dir buffer is Full!" - as per the manual.

Perhaps we should be asking what's supposed to happen when Database browser overflows the buffer.