Deadzones for fuze+ touchpad's buttons

[BenBrown]

Update: pamaury rewrote most everything, you know, so it would be correct and have everything work as you would expect it

Here is the gerrit link, http://gerrit.rockbox.org/r/#/c/677/

This adds an entry under the system settings, giving you a choice from 0% to 100% for your dead zones.  Works very well for me, even at the maximum

[pamaury]

That's an interesting suggestion. I'm not sure I have heard anyone else suggest it so I'll try myself to see what the effect. For reference, did you try several values for the dead zones and if you did, what would be the values you would consider comfortable ?
I think it will be hard to please everyone, but maybe we can introduce a setting if people feel it's useful.

[BenBrown]

did you try several values for the dead zones

No, after studying a graphic representation of the touchpad's coordinate structure, I kinda just plugged in values that seemed reasonable.  This player is my daily driver, so far it seems comfortable at 400x300

but maybe we can introduce a setting

I didn't consider that, sounds good to me I like that idea.  Let me see what I can do.

[Julian67]

I just built with these settings and as a fellow member of the fat fingered fraternity I can say it is really helpful.  I much prefer to occasionally miss a press than to press the wrong button.

[silvertree]

As a user, this proposal interests me. 

I appreciate your involvement.

[monoid]

Good idea! I do not have thick fingers, but still I sometimes hit different key than intended.

It might be handy if this idea would be incorporated in the main branch of firmware development.

[metaphys]

Indeed this a great idea

[pamaury]

Hello,
for those who can compile, here is the patch we have come up with: http://gerrit.rockbox.org/r/#/c/677/
And for those who can't compile, here is a prebuilt version with current HEAD: https://www.dropbox.com/s/vsksdgfjiogpyrq/rockbox_fuzep_deadzones.zip
If no one reports a blocking failure, I will commit this in a few days.

[gontofe]

Just out of interest, I get an error when building this patch for the simulator:

Code: [Select]

CP UI256.bmp
AR libuisimulator.a
LD rockboxui
/home/mike/dev/rockbox/build/apps/settings.o: In function `settings_apply':
/home/mike/dev/rockbox/apps/settings.c:1065: undefined reference to `touchpad_set_deadzone'
/home/mike/dev/rockbox/build/apps/settings_list.o:(.data+0x1c0): undefined reference to `touchpad_set_deadzone'
collect2: error: ld returned 1 exit status
/home/mike/dev/rockbox/uisimulator/uisimulator.make:34: recipe for target '/home/mike/dev/rockbox/build/rockboxui' failed
make: *** [/home/mike/dev/rockbox/build/rockboxui] Error 1

Is there any extra configuration required to set this up?

[pamaury]

That's a good point, the patch is not intended for the simulator. Implementing dead zones in the simulator would be quite some work, for very limited interest since the code would be completely different from target code. I have uploaded a new version to fix the compile issue.

[gontofe]

Hi there, this seems to work quite well.

Finally got everything patched and compiled and running on Fuze+.

Not sure if it's one of those settings that I'll get obsessed with fine tuning, and then at some point update Rockbox and forget to set it again! I've had a bit of a play around (chiefly using the 'search' function as the on-screen keyboard provides quite a good test), and it seems to provide a fairly good range. Lowest values are noticeably more likely to trigger unwanted keys, higher values require more deliberate presses.

All good!

[BenBrown]

gontofe - I agree, I've been using this for a few months, it's great.  It really lowers the level of frustration I was having with my Fuze+.

Pamaury - I've added a patch to gerrit, the deadzone entry for the fuze+ manual.  I don't see you much on IRC, conflicting schedules I guess,  but if you feel everything is good with this feature, IMO it's ready to merge.

[pamaury]

Great, that looks fine.  I'll have a look at the resulting PDF and if no one objects, I'm going to commit both the deadzone and manual entries.

[BenBrown]

Awesome, BTW sorry for disappearing for a few months out of the blue.

[pamaury]

Patches have been committed. Thanks to everyone for testing and big thanks to BenBrown for the manual entry.