Clip Zip 'Hold' doesn't work with the radio

[htc]

I have a Clip Zip with 3.13 on it. The Hold feature (home + select) works for file playback but not for the radio. Is this the way it is supposed to be or is this a bug?

If this is the way it's supposed to work it would be nice to get it changed. It's quite annoying to suddenly lose your station,  it's not like you can rewind the radio!

[saratoga]

The Zip is the first target to have both a radio and no hardware hold switch, so I don't think this has ever been implemented. 

[htc]

So, where do I go to add this to a wish list for the Clip Zip?

Should I report this as a bug? It seems obvious to me that 'Hold' should work for radio the same way it works for playback(and the manual doesn't mention that it won't) .
Or...
Should I request it as new feature?

[AlexP]

Well...

We don't take feature requests, and it isn't really a bug, as it isn't intended to work (although I agree it should).

[htc]

So... file a bug report and see what happens?

[AlexP]

No, it'll get closed as not a bug (probably).  It may even already be there   We are aware it doesn't work, hopefully someone will find the time to extend it.

Edit:  In fact it does (http://www.rockbox.org/tracker/task/12868) and there seems to be a patch on gerrit too.

[htc]

Awesome! Thank you! Looks like a very simple change, actually - only 2 files where he changes the condition

Code: (original) [Select]

while(1)
        {
            button = get_action(CONTEXT_FM, TIMEOUT_BLOCK);
            if(button == ACTION_FM_STOP)
                break;
        }

Code: (modified) [Select]

while(1)
        {
            button = get_action(CONTEXT_FM|ALLOW_SOFTLOCK, TIMEOUT_BLOCK);
            if(button == ACTION_FM_STOP)
                break;
        }

It was our first time compiling and installing Rockbox. We used these (excellent) guides:
http://www.rockbox.org/wiki/DevelopmentGuide
http://www.rockbox.org/wiki/HowToCompile

Following the trail of broken skulls and error messages, we finally got the right gcc installed and successfully compiled and installed Rockbox! Doesn't look like we have our fix yet, but the sense of accomplishment is strong! ;-)

We believe the freshly compiled version was copied over because our display preferences and saved radio stations were lost. Specifically, we renamed the existing .rockbox to .rockbox.bak, and copied in our freshly compiled .rockbox. Key lock still works in the What's Playing Screen, but unfortunately it doesn't look like it works on the radio.

Maybe we did something wrong? This is basically what we did:

Clone latest from git: git clone git://git.rockbox.org/rockbox
Pulled the changes from Amaury Pouly on gerrit: git fetch git://git.rockbox.org/rockbox refs/changes/21/421/1 && git checkout FETCH_HEAD
(got some message about detached head? didn't seem to be a problem.)
/tools/configure && make && make zip
on player, .rockbox becomes .rockbox.bak
copy over and extract our rockbox.zip

And all was joyous in the land! Except the key lock thing. Anyway, thank you for your help so far. Anything we're obviously missing? Thank you!
htc