Support and General Use > Theming and Appearance Customization
How can the Peak Meter be disabled?
[Saint]:
--- Quote from: bluebrother on April 06, 2013, 07:19:22 AM ---
--- Quote from: Marcel on April 06, 2013, 12:45:37 AM ---There is no good design reason not to include an override to disable the peak meter in Settings/General Settings/Display/Peak Meter whether a particular theme has it or not.
--- End quote ---
And then having to handle user complaints / "bug" reports because the "peak meter doesn't work even if the theme enables them"?. No thanks.
--- End quote ---
I kinda hate to say it, but, that shouldn't even really be a consideration.
The theme .cfg itself could enable/disable (though a theme would only ever want to enable it, I imagine, disabling it via a theme is useless) the peak meter if it was indeed a configurable setting (themes can include any setting a .cfg allows, but the theme site only allows a subset {which could be changed}). You could even make the theme engine include the smarts to turn the peak meter on if it is disabled in the settings and a theme uses it but doesn't specify to turn the peak meter on in the theme .cfg. (so that older themes would still "just work").
Now, let me clear this up:
Do I think it should be configurable? No.
Could it be? Yes, certainly.
[Saint]
Lots of edits later: I like brackets.
saratoga:
--- Quote from: Marcel on April 06, 2013, 02:14:16 AM ---
--- Quote from: saratoga on April 06, 2013, 01:03:22 AM ---If you disable it you're just going to make theme look weird
--- End quote ---
Huh? It would just make the area where the peak meter would appear empty.
--- End quote ---
Which is why its a bad idea.
Crafty:
hmmmm....my guess...
the manual is referencing the setting that stop the Peak Meter routine from running when the backlight is off is:
settings>general>settings>display>peak meter>Clip Counter
If it's not counting how many times the amp clips, there is no reason for dev to have the routine running when the backlight is off.
Marcel:
--- Quote from: bluebrother on April 06, 2013, 07:19:22 AM ---
--- Quote from: Marcel on April 06, 2013, 12:45:37 AM ---There is no good design reason not to include an override to disable the peak meter in Settings/General Settings/Display/Peak Meter whether a particular theme has it or not.
--- End quote ---
And then having to handle user complaints / "bug" reports because the "peak meter doesn't work even if the theme enables them"?. No thanks.
Just because you don't like a decision that has been made years ago (and nobody complained!) doesn't make it "bad design". I would like to disable this "select whole line (but context menu only if you're on the filename)" feature in Windows Explorer's "details" view but there's no option to do so. Does this make it "bad design"?
--- End quote ---
Your arguments are bizarre to say the least. No UI option to disable the peak meter can be implemented, because the empty space where the peak meter used to be would look "weird" or demented users would disable it, forget and then complain (lol). But if they are demented, perhaps they edit a theme, forget and then complain (lol). You are just rationalizing your personal biases and can't give a sound justification for a design choice. If you Google "Rockbox peak meter", Google suggests "Rockbox disable peak meter". That Rockbox users have to Google something as basic as this enough for it to show up as a Google suggestion should give you pause. Or perhaps Rockbox users really are demented.
saratoga:
--- Quote from: Marcel on April 07, 2013, 01:18:15 AM ---If you Google "Rockbox peak meter", Google suggests "Rockbox disable peak meter".
--- End quote ---
All old threads probably from back when we had the peak meter on by default. Now its only enabled when a user chooses a theme with it.
--- Quote from: Marcel on April 07, 2013, 01:18:15 AM --- That Rockbox users have to Google something as basic as this enough for it to show up as a Google suggestion should give you pause.
--- End quote ---
Nah, you just don't understand the context behind your question.
Anyway, since you realize why this is a bad idea and are just repeating the same point over and over, there is really no point in discussing this further.
Navigation
[0] Message Index
[*] Previous page
Go to full version