Hint on changing key or menu mapping

[WarpEnterprises]

Hi!
I'm aware that there is no way to customize keys or menus (which I find a pity),
but I'm willing to try doing it by changing code. Sadly I was not able to find where to start for my task.

I'm running RB on a SansaClipZip. I would like to mark a song as "bad" (for later deletion) with as few clicks as possible.
What would be the easiest way:

• change the rating of the playing song to 1, e.g. long press button up and entering "set song rating" instead of entering the pitch screen
• delete the song
• set some file attributes
• write out a textfile

Pleasy, any ideas to achieve this are welcome!

[saratoga]

None of that is going to be easy.

Why can't you just delete the song?

[AlexP]

Remapping existing keys is easy, assigning new actions less so.

[WarpEnterprises]

Thanks for your replies.

Simple deleting: it needs 5 clicks and makes it much more difficult to sync it to the music collection on my PC

What do you mean by "remapping existing keys"? Make changes in keymap*.c?

Can you please give me a hint where in the code the order of the menu items is written? By reordering the wps context menu so that "song rating" is the first entry I would be nearly done.

I suppose it's no easy change to open the "song rating" screen instead of the wps context menu?

[saratoga]

I think on many targets this can be done by setting a hotkey to delete or song ratings (section 4.5 of the manual for devices with the feature).  However, the Zip doesn't have hotkeys enabled in sansaclipzip.h due to either a lack of buttons or a lack of someone enabling them.  You could take a look at that mechanism and see if it works for you. 

[WarpEnterprises]

I was able to get the virtualbox-environment running, find and change all I needed.
Compiling and running rockboxui worked fine.
BUT when trying to do a Normal build there was the following error:  :'(

..../rockbox/apps/recorder/jpeg_idct_arm.S:363: Error: undefined symbol `pix8_size' in operation

This error is in a place where I don't have any clues what goes wrong.
With a full text search I didn't find a symbol definition of pix8_size.
Please help!

[saratoga]

Is that with completely stock code?  Or did you modify something?  If its stock code, I would do a 'make clean' and then try to build it again. 

[WarpEnterprises]

Thanks, make clean did it!

Making the changes was indeed quite easy, finding the right code locations was not so easy.

In case somebody else has similar needs, I changed:
sansaclipzip.h, 220: uncommented #define HAVE_HOTKEY
root_menu.c, 490, menu_table: order of root menu
onplay.c, 936, set_rating_inline: ratings only from 0 to 2
onplay.c, 1177, onplaymenu_callback: order of WPS context menu

[saratoga]

Does the hotkey seem to work normally?  maybe it should be enabled in all builds.

[[Saint]]

As far as I am aware, it can't be enabled on *all* builds (conflicts due to crowded keymaps, etc.), but if it works here and doesn't cause any regression...go for it. I'm willing to guess that there is *some* reason why this target never got it (the author was quite thorough in this respect)...but it could indeed be oversight.


[Saint]

[WarpEnterprises]

So far I didn't see anything negative by enabling the hotkey.
It's the DOWN REPEAT button which shows the playlist without hotkey, this function can be assigned to the hotkey anyways (but I assigned it to "delete").
Are there hints what is supposed to NOT "work normally"? Of course I can do some tests, if it helps.

[WarpEnterprises]

          
Now I am really happy. I found the place where to put a little piece of code, so now each time a file is deleted it's logged to a text file.

Code: [Select]

onplay.d, delete_file_dir, before end of function:
int fd = open("/deleted.txt", O_CREAT|O_WRONLY|O_APPEND, 0666);
if (fd >= 0)
{
   fdprintf(fd, "%s\n", file_to_delete);
   close(fd);
}