Support and General Use > Plugins/Viewers
gif framecount maximum - variable?
saratoga:
--- Quote from: whiskers75 on January 09, 2013, 01:57:56 AM ---Yes. I haven't bothered to implement a way of getting the finished build yet.
--- End quote ---
Well then your reply to this thread was kind of a waste of everyone's time ...
torne:
--- Quote from: whiskers75 on January 09, 2013, 01:57:56 AM ---Yes. I haven't bothered to implement a way of getting the finished build yet.
--- End quote ---
You may not realise this, but probably 99% of the users here on the forum have never built Rockbox and don't know how. The original poster here already said in the thread that they haven't compiled it before and doesn't want to. You've only done the *easiest* part for them (changing one number in one file), and left them to do the part they wanted help with :)
blissorient:
yeah- basically.
i mean, i didn't want to be rude (mainly because rudeness isn't going to get me a build) but i'm able to search for GIF_MAX_FRAMES in gif_decoder.h (i.e. i'm not retarded) i just don't have a unix operating system or experience compiling source code. although if nobody can/will easily do it for me then i guess i'll have to make my first foray into the world of development. or convert my gifs to mpgs. although i'd rather use the gifs - they're nice and small and loop well....so if anyone fancies adjusting GIF_MAX_FRAMES in gif_decoder.h to 72 or higher and compiling the code i'd be real happy!!
thanks again all!
wodz:
In theory we could allocate all memory from pool and get rid of GIF_MAX_FRAMES - the only hard limit would be available memory then. Maybe I'll look into it but no promise.
blissorient:
thanks wods :) i don't know how much memory the sansa e260 has, but the gifs i'm trying to view are all relatively small - most under 40kb and none over 80kb - so for my purposes it would be fine to simply up maxframes (pref to 100).
of course there may be other users with higher-end devices, more memory, and desire to view larger gifs so maybe in the grand scheme of things your plan may be better. is the maxframes entry there to stop imageviewer from hogging resources and locking the device up? might it be advantageous to limit imageviewer's memory usage rather than gif framecount? in my case 70 frames at 100x125 are small files but there must be other cases with low framecounts and high resolution giving large filesize and thus high memory use? furthermore might it be cool n groovy to limit to a percentage of total available memory so the same code can upscale to higher-memory devices?
this isn't my computer and i doubt the owner would appreciate me installing linux/unix in his absence and it doesn't have an optical drive so until i get my own laptop next month i am unable to get involved in coding, so in summary, thanks for all your help - all of you! may your gods (i like pan best) bless you ;)
x
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version