Third Party > Unsupported Builds

Sansa Clip+: whiskers75/rockbox

<< < (2/2)

whiskers75:

--- Quote from: [Saint] on January 01, 2013, 07:13:21 PM ---Another reply for a seperate issue...

I notice you doing some "weird sh*t (TM)" in your repo. Which is fine, it's your repo...it doesn't need to make any sense I guess.

One example, is your commit: "Boomshine total score doesnt work on a clip+"

The "fix" for this, is apparently, to disable total scores for *every* target...which seems a little odd to me since checking if the player is a "Clip" type is trivial (If it fails on Clip+, it'll fail on the others too {resolution, I'm guessing}). I'm also not entirely sure that disabling it altogether is the best option, it's your score...without this, playing the game doesn't seem particularly fun. The simpler option would be to simply alternate the level/total points on players where we know we can't display all this info at once.

There's more, but, it's your repo. I'm not going to say you should do X, Y or Z without knowing whether or not your care about breaking other targets for the sake of one or not.


[Saint]

--- End quote ---

I'll fix that. (This is a clip+ build, but it's a good idea to keep it compatible with the others)

Navigation

[0] Message Index

[*] Previous page