Rockbox Development > Feature Ideas
day / night mode by hour
gevaerts:
Can you do TSR plugins in lua?
whiskers75:
Turns out you can't.
whiskers75:
It's done!
Set dnenabled = 1, night = (24-hour clock hour at which to change brightness eg 22 for 10pm) and nightbright to a brightness value (eg 2) in the config file (? I think that should load such things into global_settings) to enable day/night support. Get the source from whiskers75/rockbox branch day/night.
Open pull request: https://github.com/whiskers75/rockbox/pull/2 - will go through if it works.
PLEASE NOTE THAT THIS IS HIGHLY EXPERIMENTAL AND MAY CAUSE YOUR PLAYER TO EXPLODE. MY ADVICE IS TO RoLo THE UPDATED BINARY FROM YOUR CURRENT VERSION.
AlexP:
We don't use github, so that pull request is pointless. If you want it considered, upload it to our gerrit.
bluebrother:
--- Quote from: whiskers75 on January 07, 2013, 10:06:45 AM ---PLEASE NOTE THAT THIS IS HIGHLY EXPERIMENTAL AND MAY CAUSE YOUR PLAYER TO EXPLODE. MY ADVICE IS TO RoLo THE UPDATED BINARY FROM YOUR CURRENT VERSION.
--- End quote ---
Or it might not work at all. I've had a short look at what's in the pull request (not that this is going to get pulled -- as AlexP already said we're not using github). Have you actually tried it? At least the code I've seen will never work. You've mixed up code with preprocessor statements in a way that simply cannot work.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version