day / night mode by hour

[rbhawaii]

hello
i made two config files one called DAY and one called NIGHT
one is super bright with white bold font, and one is super dim with thin dark yellow font, this is great for the ipod video in the car

is it possible to have rb activate one at 7pm and activate the other at 6am?

if not is this a feature the developers are interested in looking at?

thanks!

[KiwiCam]

Well. That's one way of getting around the day/night issue. It should be possible to set the theme to change all the colours after and before a certain time, but that's a lot work. Especially if you frequently change themes.

http://forums.rockbox.org/index.php/topic,35804.0.html

[rbhawaii]

i read the link you posted above where the person requested a auto contrast change, and i think that would be hard considering that my ipod and rb have no contrast settings (only led brightness settings) so i can imagine that a contrast feature would be a lot to code... BUT my feature request seems to be an easier deal. simply have rockbox load a (user created) config file at one time and another (user created) config file at another time. inside the config file are the screen brightness settings the font and colors and anything else you want.

 i have already been doing this manually for about 5 years the real minus of doing it manually is this... when you turn on rb the next day and its still set to super dark "night mode" from the night before its near impossible to see anything on the screen with the sun light out side, so my feature request would solve that problem automatically, it would be so great

[KiwiCam]

That person was me. What I'm referring to in that thread is Menu/Settings/General Settings/Display/LCD Settings/BRIGHTNESS.

Just replace in your mind the word contrast with brightness (which is actually mentioned i that suggestion). Either way, if there's a way of changing the BRIGHTNESS as a quick toggle, or a preset time period ie evening to morning/Morning to evening, than that's what I'm after.

I too like it bright during the day, but during the night (say I wake up and decide to switch it on) it's way too bright. I have to hold my Clip right up to my face to read the screen (as I'm not wearing my glasses in bed) and a Day/Night toggle or timed toggle would be a great feature.

[whiskers75]

I'll see if I can add this into whiskers75/rockbox. 
Please note that this is NOT stable in any way and may cause your player to explode. Just RoLo the code instead of installing it to be safe!
Updates:
1 - Found the brightness toggle - in apps/settings.c - backlight_set_brightness();
2 - Need a way to access the time, and update accordingly. Devs?
3 - If I'm right, I should use 'struct tm *time' 'get_time()' from timefuncs.h.
4 - Commit 3abee1f3f948266f38e7004f240e64060323039a in branch day/night: I've added a little test to see if I can get the hour and minute. If someone could test this, I would be grateful.

https://github.com/whiskers75/rockbox/commit/3abee1f3f948266f38e7004f240e64060323039a

5 - Commit c74f15db9775d8110cc429c7377b916b7d6c2a69 in branch day/night: I've added in THEME_TIME. Could some dev help here?

https://github.com/whiskers75/rockbox/commit/c74f15db9775d8110cc429c7377b916b7d6c2a69

6 - Prototype 1 is coming on! (Sorry for my sucky C code, I'm new to C)

7 - Commit 0b688a3ba0fba9177757fc7e8eb316c424d7b836 in branch day/night: Day/night should be working now! Just configure a few global_settings - .dnenabled, .nighttime, .daybright and .nightbright!

https://github.com/whiskers75/rockbox/commit/0b688a3ba0fba9177757fc7e8eb316c424d7b836

[whiskers75]

If we could get a developer or someone with more knowledge than me in here, that would be good.

[rbhawaii]

i dont know if this helps or matters
the day and night config files change this info

font bold/regular
font color
led brightness

i found only those 3 are needed for the change every 12 hours
 

[whiskers75]

i dont know if this helps or matters
the day and night config files change this info

font bolt/regular
font color
led brightness

i found only those 3 are needed for the change every 12 hours

Yes, I am trying to implement LED brightness. Currently, 'night-time' is classified as 22:00 -> 00:00. I'll try to implement a config option for it.

[whiskers75]

What brightness value would you like for day and night?

[JdGordon]

I think you are going about this completely wrongly.
Why don't you write a plugin which stays active (like battery_bench) which checks the time against some *configurable* value and runs a day.cfg config if it changes to day and a night.cfg config when it changes to night? then  questions about brightness is up to the user and not randomly/arbitrarily chosen by "someone on the internet"?

edit: If its done in a plugin there is a far bigger chance of it being accepted into mainline

[whiskers75]

Good idea, I'll try that.
EDIT: I think I'd much rather have it in main.c as then it could be configured easier.

[[Saint]]

EDIT: I think I'd much rather have it in main.c as then it could be configured easier.

I'm curious what makes you think this.


[Saint]

[rbhawaii]

these are my day and night night config settings on the ipod 240gb video

day...
brightness: 22
foreground color: FFFFFF
background color: 000000
line selector start color: FFFFFF    
line selector end color: FFFFFF          
line selector text color: 000000
font: /.rockbox/fonts/24-neep-alt-12x24-bold-L1.fnt



night...
brightness: 2
foreground color: 948A31
background color: 000000
line selector start color: 000000
line selector end color: 000000
line selector text color: FFFFFF
font: /.rockbox/fonts/24-neep-alt-12x24-L1.fnt

[whiskers75]

When I get my code working, you should be able to set 'daybright: 22', 'nightbright: 2', 'dnenabled: 1' to get brightness working.
[Saint], if I were to do it in a plugin, how would I access global_settings?
Current build status:

[JdGordon]

rb->global_settings