Support and General Use > Plugins/Viewers
Doom on Sansa Fuze+ is unplayable, because it's running super fast
dorotik:
--- Quote from: saratoga on March 25, 2012, 06:07:15 PM ---I don't see why a fix should require a menu setting.
--- End quote ---
Me neither. But as I'm just starting with Rockbox development and I don't have experience with other devices emulators, I would like to avoid submitting a change which may not work properly on other players than Fuze+. Anyway, do you have some advice on how to correctly proceed with this fix?
saratoga:
--- Quote from: dorotik on March 25, 2012, 06:20:19 PM ---Me neither. But as I'm just starting with Rockbox development and I don't have experience with other devices emulators, I would like to avoid submitting a change which may not work properly on other players than Fuze+. Anyway, do you have some advice on how to correctly proceed with this fix?
--- End quote ---
Push your fix to gerrit with a description of how it works. Then someone can review it. Until then its impossible to help you, since I don't even know if what you have is acceptable.
Also, we don't actually have device emulators, so other people will need to test this on another device.
Edit: Also, if you haven't seen these already, we have a development guide (link on the left side of the screen) and a specific guide to submitting code changes with git:
http://www.rockbox.org/wiki/UsingGit
Of course you are welcome to ask on IRC if you have trouble with any of our tools.
dorotik:
--- Quote from: saratoga on March 25, 2012, 06:24:46 PM ---
--- Quote from: dorotik on March 25, 2012, 06:20:19 PM ---Me neither. But as I'm just starting with Rockbox development and I don't have experience with other devices emulators, I would like to avoid submitting a change which may not work properly on other players than Fuze+. Anyway, do you have some advice on how to correctly proceed with this fix?
--- End quote ---
Push your fix to gerrit with a description of how it works. Then someone can review it. Until then its impossible to help you, since I don't even know if what you have is acceptable.
Also, we don't actually have device emulators, so other people will need to test this on another device.
--- End quote ---
Ok, thanks
kilr0y:
What with that fix for Fuze+?...
I tried the posted file, but says "Incompatible"...
bluebrother:
--- Quote from: saratoga on March 25, 2012, 05:56:38 PM ---Its usually better if you submit the fix rather then the binary. Both since we're a GPL project, and also since plugins are meant to be recompiled with every build and tend not to work well when copied between different compilations.
--- End quote ---
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version