Doom on Sansa Fuze+ is unplayable, because it's running super fast

[dorotik]

When I try to play Doom on Sansa Fuze+ (Rockbox e07b22f-120315), the game runs insanely fast, thus it's unplayable. Is there some way to fix it? Thanks

[dorotik]

Fixed it  .

Here's link to the modified doom.rock file: http://www.wuala.com/dorotik/RockboxShared/

Just copy it on Fuze+ into .rockbox/rocks/games folder. I'll submit this fix for Rockbox build later on. Have fun!

[saratoga]

Fixed it  .

Here's link to the modified doom.rock file: http://www.wuala.com/dorotik/RockboxShared/

Just copy it on Fuze+ into .rockbox/rocks/games folder. I'll submit this fix for Rockbox build later on. Have fun!

Its usually better if you submit the fix rather then the binary.  Both since we're a GPL project, and also since plugins are meant to be recompiled with every build and tend not to work well when copied between different compilations. 

[dorotik]

Fixed it  .

Here's link to the modified doom.rock file: http://www.wuala.com/dorotik/RockboxShared/

Just copy it on Fuze+ into .rockbox/rocks/games folder. I'll submit this fix for Rockbox build later on. Have fun!

Its usually better if you submit the fix rather then the binary.  Both since we're a GPL project, and also since plugins are meant to be recompiled with every build and tend not to work well when copied between different compilations. 

Of course I will submit sources, not binary. This is just a quick post. I yet want to add option into Rockbox pre-game menu for enabling this Fuze+ speed fix, just be be on the safe side there won't be no adverse effects on other devices.

[saratoga]

I don't see why a fix should require a menu setting. 

[dorotik]

I don't see why a fix should require a menu setting. 

Me neither. But as I'm just starting with Rockbox development and I don't have experience with other devices emulators, I would like to avoid submitting a change which may not work properly on other players than Fuze+. Anyway, do you have some advice on how to correctly proceed with this fix?

[saratoga]

Me neither. But as I'm just starting with Rockbox development and I don't have experience with other devices emulators, I would like to avoid submitting a change which may not work properly on other players than Fuze+. Anyway, do you have some advice on how to correctly proceed with this fix?

Push your fix to gerrit with a description of how it works.  Then someone can review it.  Until then its impossible to help you, since I don't even know if what you have is acceptable.  

Also, we don't actually have device emulators, so other people will need to test this on another device.  

Edit:  Also, if you haven't seen these already, we have a development guide (link on the left side of the screen) and a specific guide to submitting code changes with git:

http://www.rockbox.org/wiki/UsingGit

Of course you are welcome to ask on IRC if you have trouble with any of our tools. 

[dorotik]

Me neither. But as I'm just starting with Rockbox development and I don't have experience with other devices emulators, I would like to avoid submitting a change which may not work properly on other players than Fuze+. Anyway, do you have some advice on how to correctly proceed with this fix?

Push your fix to gerrit with a description of how it works.  Then someone can review it.  Until then its impossible to help you, since I don't even know if what you have is acceptable. 

Also, we don't actually have device emulators, so other people will need to test this on another device. 

Ok, thanks

[kilr0y]

What with that fix for Fuze+?...
I tried the posted file, but says "Incompatible"...

[bluebrother]

Its usually better if you submit the fix rather then the binary.  Both since we're a GPL project, and also since plugins are meant to be recompiled with every build and tend not to work well when copied between different compilations. 

[dorotik]

Updated the file in a link to be compatible with current Rockbox, also improved the speed of game. Will submit sources asap.

[AlexP]

Is the only change here the one you uploaded to gerrit?

[dorotik]

Is the only change here the one you uploaded to gerrit?

yes

[saratoga]

If I understand correctly, the problem here is that the user timer isn't running at 100hz like its supposed to be.  If this is just a simple bug, we should probably just ask pamaury if he can fix it. 

[dorotik]

If I understand correctly, the problem here is that the user timer isn't running at 100hz like its supposed to be.  If this is just a simple bug, we should probably just ask pamaury if he can fix it. 

The timer is supposed to tick at 70Hz. The 100Hz check is there only as a precaution in case somebody messes with the define. I tried to adjust the user timer, but something isn't right with it. As I don't have an experience with Rockbox, it would be good if somebody could have a look on it. In the meantime, the fallback solution which was already there for greyscale targets works perfectly on Fuze also.