Drawing Lists Using A Skin Examples?

[OzzieJacks]

I am trying to write a theme that uses the skin engine to draw its lists (%Lb tags etc) but so far I am not having any luck.  The only documentation I could find on it was here http://www.rockbox.org/wiki/Main/CustomWPS#Drawing_the_lists_using_a_skin and here http://www.rockbox.org/mail/archive/rockbox-dev-archive-2011-07/0020.shtml.  Are there any themes or examples out there that have used this functionality?

If I use the following example from the Custom WPS wiki page I get a segmentation fault.

Code: [Select]

%?cs<%Lb(a,100,20)|> 
%V(0,0,10,-,1)%Vf(aabbcc) 
%?LB<%LB(0,0,10,185, invert)> 
%Vi(-,10,0,-,-35,1) 
%Vl(a,5,5,160,12,1) 
%s%?Lc<%Vg(00ffaa, ff0000, 000000)%Vs(gradient)%>%>%>%ac>zzzzzzz %LT zzzzz%s%?Lc<%ar%<%<%<> 
%V(0,185,-,-,1) 
%s%LT

If I take the %Lb tag out of the conditional the segmentation fault disappears but the code has no effect.

I am using a current Linux SDL build and I have also tried it on a few UISimulators.  I will try to do a 3.10 release build of the SDL tommorow just in case something was broken since the last release.

 

[gevaerts]

I get a segfault too these days with my "demo" skinned list theme. I'm trying to find the bug.

I also want to upload that theme soonish. I finally found a matching font that I can redistribute...

[gevaerts]

OK, the segfaults are gone, but things still don't seem to be working right :(

[JdGordon]

bugger, sorry.
If i don't pass out tonight i'll try to remember to go over skin lists and see what the issue is.

OzzieJacks: If you are interested in skinning jump on IRC and talk to me and [saint]. we need more users playing with skins to find more issues, and especially if oyu want to play with skinned lists

[OzzieJacks]

gevaerts, JdGordon: Thanks for looking into the problems with skinned lists.  As you stated they do not segfault with the latest commits but don't seem to display either 

Once skinned lists are working will the following code work?

Code: [Select]

# 1024x768 screen
# minimal skinned list with no line selections
%wd
#
%?cs<%Lb(a,800,40)|> #make each list item on the menu screen 800 wide by 40 tall
#
%Vi(-,0,0,-,-,1) #use the full screen for a UI viewport
%Vl(a,0,0,-,-,1) #use the full area of the list item box 800x40
%s%LT            #just display the list item text for each line

I will be happy to join you on IRC and help with testing.

[gevaerts]

I think I've found the remaining bugs.  If you apply http://gerrit.rockbox.org/112 and http://gerrit.rockbox.org/113 things should work fine again. I haven't pushed those to the official tree yet because this is code I'm not too familiar with and I want JdGordon to review them first.

If all goes well, those fixes should be in by sometime tomorrow. When that's done I'll upload some of my skinlist-using themes for the world to look at.

[gevaerts]

OK, I've now uploaded two themes that use skinned lists:

http://themes.rockbox.org/index.php?themeid=1535&target=gigabeatfx
http://themes.rockbox.org/index.php?themeid=1543&target=gigabeatfx

I'm not sure if -,- as width,height will work in list item viewports, it's possible you have to specify the actual size. Apart from that, your code should work I think.

[audio-i]

OK, I've now uploaded two themes that use skinned lists:

http://themes.rockbox.org/index.php?themeid=1535&target=gigabeatfx
http://themes.rockbox.org/index.php?themeid=1543&target=gigabeatfx

Really cool

[OzzieJacks]

OK, I've now uploaded two themes that use skinned lists:

http://themes.rockbox.org/index.php?themeid=1535&target=gigabeatfx
http://themes.rockbox.org/index.php?themeid=1543&target=gigabeatfx

I'm not sure if -,- as width,height will work in list item viewports, it's possible you have to specify the actual size. Apart from that, your code should work I think.

Nice themes  .  Thanks for the examples and fixes.  It's amazing what can be done with this. 

I just tried a few skinned lists I am working on and it all seems to work except for one Floating point exception I got but I haven't been able to reproduce it.  -,- also seems to work for width, height.