Rockbox Development > New Ports

Creative Zen Vision:M

<< < (99/136) > >>

mcuelenaere:

--- Quote from: Falafel on March 11, 2008, 03:06:31 PM ---First number is just pressing it, second is when you release it or keep it pressed a bit longer
Also, all the value are preceded by FFFF

...

There doesn't seem to be a button long value

--- End quote ---
Here's an updated diff with your values added: to enable them, uncomment the last line in export/config-creativezvm.h

Please test them and tell me if there's something wrong (I also updated the BASEPX and BASEPY in lcd-creativezvm.c so you won't need to do that).

But I'm thinking in the future, the Creative Zen Vision should be a port on it's own cause it seems it uses some different buttons as the ZVM does (but we could preserve the files used in tms320dm320/creative-zvm/xx-creativezvm.c; we could make separate ones for the zen vision). What do others think?

edit: it seems I added some unwanted test stuff, @Falafel: recomment #define DO_THREAD_TEST

Falafel:
Well, I would say that given the minute differences till now, it would be useless to make it completely seperate.. A few defines for things like BASEPX and such should be enough.. at least, as long as the differences don't grow to big.

mcuelenaere:

--- Quote from: Falafel on March 11, 2008, 03:28:19 PM ---Well, I would say that given the minute differences till now, it would be useless to make it completely seperate.. A few defines for things like BASEPX and such should be enough.. at least, as long as the differences don't grow to big.

--- End quote ---
Ok, but if we're going to add the 60GB, the 30GB, the Zen Vision and perhaps the Zen Vision:W won't it be better if files are separated ?
But you're right, as for now this is the best solution.

One thing is bugging me (and which doesn't affect your device apparently) is that I don't get a 'button-release' value..
For now, there's just a built-in check that removes the currently pressed button after 40 ticks; but this isn't a very good solution and I thought maybe some kind of polling method to the PIC could solve problems (and I believe there's one according to OF, but I haven't figured it yet out how); so I'm puzzled why the Zen Vision has this and why the ZVM not...

BTW: what I meant with 'long value' is just what you reported: the 0F01 vs 0F00

Falafel:
Yes, but this value is shown whenever you release a button OR hold it longer.. but well, I suppose it's alright.

Btw. when I load your diff in tortoise, I do not see any changes to button-creativezvm.c?

mcuelenaere:

--- Quote from: Falafel on March 11, 2008, 03:39:20 PM ---Yes, but this value is shown whenever you release a button OR hold it longer.. but well, I suppose it's alright.

Btw. when I load your diff in tortoise, I do not see any changes to button-creativezvm.c?

--- End quote ---
Arg, I forgot to do a 'svn add button-creativezvm.c' !
Anyway, here's the correct diff..

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version