Rockbox Development > Feature Ideas

ALBUM ART for Files

(1/2) > >>

wildertux:
Hi, sorry for my bad English!
I have my musik on my PC with mp3 files, and there in id3v2.4 tags, APIC (Picture) Frames like Front-Cover, Back-Cover, Lead Performer, and more!
Rockbox will read nothing if there more as one APIC frame!
Front Cover is not a big Problem, just add cover.jpg in Album Folder! (see Manual Appendix for more ways)
but i will, i will, i will see "Lead Performer" in wps:
    there was only the way, <filename.jpg>, but i will not see filename.jpg on folder-view:
        there was a filefilter that can i put on only Music-files, but i have Video-files!
            Crash no more Options :-

so my Question/Idea for better view !
rockbox should looking for <.filename.jpg> or <filname.jpg>!
I think all the people they use filename will show for any file a other Picture in wps, and i think they all will not see this files in File-Browser!

Post Merge: January 31, 2012, 09:02:07 AMsorry for my Bad English!
I have now write a patch, but not only my English is BAD, my C too, if it be C  ::)!
it is the first time that i something changing in RockBoxCode, and i dont now how i should use git to publish this Patch!

'./apps/recorder/albumart.c'

--- Code: ---145a146
>     char filehead[MAX_PATH + 1];
148a150
>     const char *filename;
150a153,154
>     int filenamelen;
>     int fileheadlen;
169c173
<     strip_filename(dir, sizeof(dir), trackname);
---
>     filename = strip_filename(dir, sizeof(dir), trackname);
170a175
>     filenamelen = strlen(filename);
189a195,206
>         if (!found && filenamelen > 0)
>         {
>             /* if it doesn't exist,
>             * we look for a file current track with dot hidden */
>             strip_extension(filehead, sizeof(filehead) - strlen(size_string) - 4,
>                             filename);
>     fileheadlen = strlen(filehead);
>             pathlen = snprintf(path, sizeof(path),
>                             "%s.%s%s." EXT, dir, filehead, size_string);
>             fix_path_part(path, filenamelen, albumlen);
>             found = try_exts(path, pathlen);
>         }

--- End code ---

can anyone help?

Chronon:
You should first post it to the patch tracker so others can try and comment on your patch.

torne:
Follow the instructions on http://www.rockbox.org/wiki/UsingGit - if this isn't clear enough, please tell us exactly how far you got and what happened when you got stuck, and we will try and improve the instructions.

Chronon:
Is this functionality of Gerritt now the preferred method of submitting patches?  Will flyspray be deprecated for patch management?

saratoga:

--- Quote from: Chronon on February 01, 2012, 10:19:33 PM ---Is this functionality of Gerritt now the preferred method of submitting patches?  Will flyspray be deprecated for patch management?

--- End quote ---

Eventually flyspray will probably be for bug reports only I think.  But we're not quite there yet. 

Navigation

[0] Message Index

[#] Next page