Support and General Use > Theming and Appearance Customization

My Themes will no longer work in the Current Build r30819-111021 - Clip

<< < (2/3) > >>

Llorean:
I honestly can't answer that. It would probably be reasonable for someone to statically allocate a larger amount until whatever issues extant are resolved. While this may mean Rockbox temporarily dedicating more RAM to themes than necessary on affected devices, it would restore themes to working condition that apparently were broken, and wouldn't have mean that you'd have that question of "if someone downloads my theme with a supported build, will they be able to get it work? Will they even know they need this extra file?" etc.

bluebrother:

--- Quote from: Llorean on October 22, 2011, 03:18:32 AM ---Saint has been a little unclear. The feature wasn't removed, it was removed until it's implemented in an agreeable way. Even the person who wrote the previous version admitted it wasn't the right way to do it.

--- End quote ---

I would still call that as being removed :)


--- Quote from: KiwiCam on October 22, 2011, 03:30:27 AM ---But, why the reduction? Why not, at the very least, keep it at the 48.0KB? Couldn't it just be pushed up just a little bit more than what it is now?  ???

--- End quote ---

And if it's been pushed a little the next one will complain and ask it being pushed a little. And after yet another pushing the limit the next will ask ...

Sure, the situation is not really satisfying for your case. But instead of discussing about yet-another-workaround the time would be better spent to make a real solution. Reverting the skin_buffer_size.txt change wasn't one, as introducing it wasn't either. I neither liked its introduction nor its removal, and the way that went looks more like a personal fight of two individuals to me. Fortunately I'm neither involved with that case nor the affected code :)

torne:
Work is underway on making the skin elements get dynamically allocated using buflib, which will remove the need to have a large static skin buffer at all.

JdGordon:

--- Quote from: Llorean on October 22, 2011, 03:18:32 AM ---Saint has been a little unclear. The feature wasn't removed, it was removed until it's implemented in an agreeable way. Even the person who wrote the previous version admitted it wasn't the right way to do it.

--- End quote ---
I didnt like the implementation sure, but it still made everyone happy.


--- Quote from: bluebrother on October 22, 2011, 06:50:48 AM ---the way that went looks more like a personal fight of two individuals to me. Fortunately I'm neither involved with that case nor the affected code :)

--- End quote ---

100% correct. but enough people stayed quiet and let it happen.


--- Quote from: torne on October 22, 2011, 07:23:36 AM ---Work is underway on making the skin elements get dynamically allocated using buflib, which will remove the need to have a large static skin buffer at all.

--- End quote ---
Don't hold your breath. my patch is buggy as hell and unlikely to be suitable to try commiting any time soon (if ever)

sockbox:
Be patient. Themes break between releases then they magically work again.

If i recall correctly, rockbox for the clip was released with 13k of skin buffer. Now it's pushing 40k. Be paitent with the development and it'll probably be double in the near future.

Navigation

[0] Message Index

[#] Next page

[*] Previous page