Rockbox Development > Feature Ideas

Off Selection in main menu

(1/1)

ranosb:
Pressing and holding down the play/pause seems to actually make the button less responsive, (after pressing & holding the "menu & select" for reboot many times it appears now my select button is less responsive, pushed in?
By having a simple "turn off" selection in the main menu you wouldn't have to HOLD any buttons down forcing them to be more depressed...

JdGordon:
it wont be added to the standard build, but there are "add shutdown to menu" patches on flyspray if you want to build your own biuld.

[Saint]:

--- Quote from: ranosb on August 21, 2011, 11:41:25 PM ---Pressing and holding down the play/pause seems to actually make the button less responsive, (after pressing & holding the "menu & select" for reboot many times it appears now my select button is less responsive, pushed in?
By having a simple "turn off" selection in the main menu you wouldn't have to HOLD any buttons down forcing them to be more depressed...

--- End quote ---

Having to hold a button down doesn't mean that you need to apply excessive force to it...however:

This will do what you want...


--- Code: ---diff --git a/apps/features.txt b/apps/features.txt
index 93b81ff..7af5e99 100644
--- a/apps/features.txt
+++ b/apps/features.txt
@@ -150,10 +150,6 @@ rtc
 serial_port
 #endif
 
-#if defined(ARCHOS_RECORDER) || defined(ARCHOS_PLAYER)
-soft_shutdown
-#endif
-
 #if defined(HAVE_SPDIF_POWER)
 spdif_power
 #endif
diff --git a/apps/lang/english.lang b/apps/lang/english.lang
index bd52e17..cfdfdbf 100644
--- a/apps/lang/english.lang
+++ b/apps/lang/english.lang
@@ -6617,16 +6617,13 @@
   desc: in main menu
   user: core
   <source>
-    *: none
-    soft_shutdown: "Shut down"
+    *: "Shut down"
   </source>
   <dest>
-    *: none
-    soft_shutdown: "Shut down"
+    *: "Shut down"
   </dest>
   <voice>
-    *: none
-    soft_shutdown: "Shut down"
+    *: "Shut down"
   </voice>
 </phrase>
 <phrase>
diff --git a/apps/root_menu.c b/apps/root_menu.c
index 573ea94..343a926 100644
--- a/apps/root_menu.c
+++ b/apps/root_menu.c
@@ -461,7 +461,6 @@ MENUITEM_RETURNVALUE(playlists, ID2P(LANG_CATALOG), GO_TO_PLAYLISTS_SCREEN,
 MENUITEM_RETURNVALUE(system_menu_, ID2P(LANG_SYSTEM), GO_TO_SYSTEM_SCREEN,
                      NULL, Icon_System_menu);
 
-#if CONFIG_KEYPAD == PLAYER_PAD
 static int do_shutdown(void)
 {
 #if CONFIG_CHARGING
@@ -474,7 +473,7 @@ static int do_shutdown(void)
 }
 MENUITEM_FUNCTION(do_shutdown_item, 0, ID2P(LANG_SHUTDOWN),
                   do_shutdown, NULL, NULL, Icon_NOICON);
-#endif
+
 MAKE_MENU(root_menu_, ID2P(LANG_ROCKBOX_TITLE),
             item_callback, Icon_Rockbox,
             &bookmarks, &file_browser,
@@ -488,11 +487,7 @@ MAKE_MENU(root_menu_, ID2P(LANG_ROCKBOX_TITLE),
 #if CONFIG_TUNER
             &fm,
 #endif
-            &playlists, &rocks_browser,  &system_menu_
-
-#if CONFIG_KEYPAD == PLAYER_PAD
-            ,&do_shutdown_item
-#endif
+            &playlists, &rocks_browser, &system_menu_, &do_shutdown_item
         );
 
 static int item_callback(int action, const struct menu_item_ex *this_item)

--- End code ---

Copy the contents of the above code snippet to "your_patch_name".patch, and apply it following the directions on applying patches here after following the directions on setting up a development environment for Linux or Windows.



[St.]

Navigation

[0] Message Index