Could a persistent sleep timer be added to the next stable release?

[comporanger]

Hi all,
I use Rockbox on a Sansa e260. It looks to me like some developers  have been working for on patches for a persistent sleep timer. This is something I've been wanting for a while, and I was wondering if there are plans to include it in the next release. If you use a sleep timer at all the chances are good (at least for my own situation) that you'll be setting it to the same time every night. Suggestion: What about fixing it so that if you hold down the next\ff key at the same time as you press the power button on the player it activates the preset sleep timer? Otherwise it would default to normal operation. That would make it extremely easy to start your sleep timer every night, instead of navigating through a multi-level menu the way it is now. But, this would all be icing on the cake- Rockbox is a terrific OS and I'm thoroughly enjoying it. Many thanks to all the developers.

[[Saint]]

If someone (developer or otherwise) does the work needed to bring it up to a committable state with an agreeable implementation that works across all the devices it possibly can, before the next freeze period for release...then yes
Otherwise, no, no it won't.


[St.]

[nick_p]

Here's a patch that adds a persistent sleep timer, please let me know if there's anything I could change that's currently preventing it from being committed.

http://www.rockbox.org/tracker/task/10849

[saratoga]

I don't know anything about that specific area of rockbox, but the patch generally looks good in terms of style.  You should probably bug people on IRC about getting it committed.  Someone familiar with that bit of the code will have to review it to make sure theres no unforeseen problems.

[nick_p]

Thanks saratoga.

I tried on IRC a couple of hours ago but obviously chose a bad time, I'll try later.

FWIW, re problems, I've been using the patch for over a year and a half, against various revisions. It's also been included in a number of third party builds during that time and haven't heard of any detrimental effects so far.

Edit:

OK, I got a response this afternoon;

http://www.rockbox.org/irc/log-20110808#14:03:21

The plan is to retain the new Settings > General Settings > System > Sleep Timer sub-menu, but move the Start/ Stop Timer function back to its original location in the System menu.

The reasoning behind this is to keep functions out of the settings hierarchy.

Edit 2:

Changes made and positive discussions on IRC, sideral has kindly offered to raise the subject on the dev mailing list.

http://www.rockbox.org/irc/log-20110809#14:51:55

[Erasmus]

Anything preventing this from being added to the 1st Gen Archos Jukeboxes? That would be lovely.

[nick_p]

It's currently being tested & reviewed by sideral with a view to being committed.

http://www.rockbox.org/mail/archive/rockbox-dev-archive-2011-08/0085.shtml

This would mean it would be available on all platforms.

However, he was having computer problems a fortnight ago and I think this might still be the case.

http://www.rockbox.org/irc/log-20110901#09:17:23

[stuwat]

I will be overjoyed when this feature makes it into a stable release. A big thank you to the all the developers. Your work is very much appreciated.

[nick_p]

Committed by kugel: r30777 (thanks kugel).

Unless it's reverted, on track for 3.10...

[stuwat]

This is awesome!! I'm always falling asleep to the radio or an MP3 of some sort, so I love this feature. I now have my player set up so that it turns off after 30 minutes, but when turned back on again, it just resumes from where it left off. Brilliant.