Unable to patch the source code

[psgarcha92]

Hey guys
i've been trying hard to compile my own Build of rockbox for my Sansa Fuze V2 since a couple of days, and i wanted it to have the Line Out Dock patch as posted in

 "http://www.rockbox.org/tracker/task/12074?string=sansa+fuze+dock&project=1&type[0]=4&sev[0]=&pri[0]=&due[0]=&reported[0]=&cat[0]=&status[0]=open&percent[0]=&opened=&dev=&closed=&duedatefrom=&duedateto=&changedfrom=&changedto=&openedfrom=&openedto=&closedfrom=&closedto="

Now, i follow the Steps as on http://www.rockbox.org/wiki/LinuxSimpleGuideToCompiling,
and i have downloaded and installed all repositories needed, including the source code.

Now, i believe, or by as much i have understood, this is the time to apply a patch, prior to compiling.
So, i check if i have the Patch program/code installed, and i do.
now, i type in and get the following.

prabhdeepsingh@ubuntu:~$ cd rockbox/tools
prabhdeepsingh@ubuntu:~/rockbox/tools$ sudo patch < /home/prabhdeepsingh/fuze22.patch
[sudo] password for prabhdeepsingh:
patching file as3514.c
Hunk #1 FAILED at 78.
Hunk #2 FAILED at 265.
Hunk #3 FAILED at 275.
Hunk #4 FAILED at 316.
4 out of 4 hunks FAILED -- saving rejects to file as3514.c.rej
patching file as3514.h
Hunk #1 FAILED at 23.
Hunk #2 FAILED at 30.
2 out of 2 hunks FAILED -- saving rejects to file as3514.h.rej
patching file sansafuzev2.h
Hunk #1 FAILED at 209.
1 out of 1 hunk FAILED -- saving rejects to file sansafuzev2.h.rej
patching file power-as3525.c
Hunk #1 FAILED at 73.
1 out of 1 hunk FAILED -- saving rejects to file power-as3525.c.rej

why am i so unable to patch the files? what am i doing wrong?

[marc2003]

http://www.rockbox.org/wiki/WorkingWithPatches#Applying_A_Patch

[[Saint]]

What strip setting did you use?

The patch was generated with git, so you'll need to use the -p1 strip option.

patch -p1 < name_of_patch.patch

If after that, you still get failed hunks, then the patch is so out of sync that patch can't even make an educated guess at where to apply the code, so it will fail.
At that point you'll need to patch by hand, if it indeed comes to that.
I suspect in this case that changing the strip option will "just work", though.


[St.]

[psgarcha92]

In the page that describes Working with patches, the "patch < patchfile"
command is used first, and i use,
patch < fuze22.patch.
Using the strings is to be done after this command results in something right? In my case patch < fuze22.patch fails already, how do i use the strings then?i am going to try right now.

[saratoga]

In the page that describes Working with patches, the "patch < patchfile"

1)  p option
2)  wrong folder


A patch is just a list of files and changes to make to them.  Open up the patch and take a look at the paths it uses.   Unless your path matches the one in the patch file, you will need to use a p option.  In this case probably "-p 1".

[psgarcha92]

Ok, now i've built the Build. have completed compiling and have made the Zip by using the Make Zip command.
but where is the Zip file placed? i just cant locate it> where do i look for it? the root folder is locked, that i can just browse using the Terminal, nothing else.
Where is the Zip file that i made from the source code?

[marc2003]

you are joking right? 

(it's inside the "build" folder that you must have created and ran tools/configure and make from)

[psgarcha92]

am not kidding at all.
i am using Ubuntu particularly, there wasnt any point where i created any builds folder.
i was using cd rockbox/tools
to start compiling, but sadly, i just cant find where the folder exists.

[marc2003]

Now, i follow the Steps as on http://www.rockbox.org/wiki/LinuxSimpleGuideToCompiling,
and i have downloaded and installed all repositories needed, including the source code.

you really read that but you don't have a build folder???

Type cd ~/rockbox. The last line in your terminal should read username@computername:~/rockbox$ . Type mkdir build (mkdir means "make directory"), then type cd build . Your current line should say username@computername:~/rockbox/build$ Now type ../tools/configure - and make sure you include those two periods.

A table of ALL the devices Rockbox supports will come up, and each device will have a number beside it. Simply type the number for the device you want to make a build for. I use a Sansa c200, so I would type 52.

Next, you'll see a few choices for the type of build you'd like to make. Let's make a normal build: type n. Wait for a few seconds. When it says "Created makefile", type make (or make -j for a multicore system) and wait. Type make zip to prepare a rockbox.zip and wait a little more. That's your build, ready to install onto a real device. Use it like you would for a manual update (that is, unzip its contents into the root of your device, overwriting old files if necessary). When it's done, congratulations! You've compiled your own copy of Rockbox, and made a .zip file like the one you download from the website!

[bluebrother]

We have detailed instructions on how to build Rockbox in the wiki. If you decide not to follow them you shouldn't expect people helping you. Building from the tools folder is wrong wrong wrong and will cause you all kind of trouble. But feel free to ignore what others have already figured and documented and waste lots of time. If you can't figure it from the documentation you might be better not compiling your own build at all. You *can* seriously damage your player so making the process too simple is a bad thing.

[saratoga]

i was using cd rockbox/tools
to start compiling, but sadly, i just cant find where the folder exists.

The configure script won't' even let you build in that folder, so I don't think this is right.  What did you do?

[psgarcha92]

and how exactly did you guys come to the conclusion that i wasnt reading the instructions on the wiki? I read and followed the last guide that had been there a couple of djys ago. As i observed, i bet that the wiki has been updated yesterday or day before. And, i have compiled my version of RB with the patch already. I had to use the -p1 parameter and it finally compiled. I even used the newer wiki and was able to compile it in 20mins.
The problew i now face is, my Sansa Fuze v2 always stays in the line out mode.there is nothing in the build that lets me select between line out and headphone mode.

[saratoga]

and how exactly did you guys come to the conclusion that i wasnt reading the instructions on the wiki?

Because you didn't follow them.

I read and followed the last guide that had been there a couple of djys ago. As i observed, i bet that the wiki has been updated yesterday or day before.

Edit date:

r20 - 14 Jul 2010 - 00:10:49 - MichaelCarr

So no.  And why would the wiki have ever had instructions that couldn't possibly work?

The problew i now face is, my Sansa Fuze v2 always stays in the line out mode.there is nothing in the build that lets me select between line out and headphone mode.

The patch description describes how to disable line out mode.  Did you read it?

[Chronon]

psgarcha92 is probably talking about the edit a couple of days ago to the WorkingWithPatches page.  However, as anybody can see, the only change was to place the instructions about applying and reverting patches earlier in the page.