Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Rockbox Ports are now being developed for various digital audio players!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Audio Playback, Database and Playlists
| | |-+  [Fixed] Replaygain: Small negative gain value displayed as positive
« previous next »
  • Print
Pages: [1]

Author Topic: [Fixed] Replaygain: Small negative gain value displayed as positive  (Read 943 times)

Offline keyb_gr

  • Member
  • *
  • Posts: 40
[Fixed] Replaygain: Small negative gain value displayed as positive
« on: May 01, 2011, 02:44:45 PM »
Since doing a few vinyl rips and normalizing track volumes using Replaygain lately (Foobar2000 can do that), I found myself with a lot of MP3s with gains a little below or above 0.00 dB on my Clip+, like -0.05 dB. Track info during playback will always display these gain values as positive.

Not sure whether it's a parsing or display problem (we're talking like a tenth of a dB or less here, i.e. nothing readily audible). In any case those familiar with the code should find this a lot quicker than I would (barely managed to compile the whole shebang so far).

Currently on r29808 (problem already present in r29738).
« Last Edit: May 02, 2011, 07:23:58 AM by keyb_gr »
Logged

Offline Buschel

  • Developer
  • Member
  • *
  • Posts: 190
Re: Replaygain: Small negative gain value displayed as positive
« Reply #1 on: May 01, 2011, 05:13:06 PM »
Good catch! :o)

The code did only add the "-" if the integer part of the level was >1. All levels from -0.99 to 0.99 were displayed without sign. This did not impact the signal processing.

Fixed with r29814.
Logged
iPod 5.5G 30GB, iPod nano 2G 8GB, 97% MPC and growing...
 

Offline keyb_gr

  • Member
  • *
  • Posts: 40
Re: Replaygain: Small negative gain value displayed as positive
« Reply #2 on: May 02, 2011, 07:22:54 AM »
Great. Seems fixed indeed. Took me a while to get what had been wrong, but then I lol'd. -0 is (+)0... normally. Too smart for its own good... ;)
Logged

Offline Buschel

  • Developer
  • Member
  • *
  • Posts: 190
Re: [Fixed] Replaygain: Small negative gain value displayed as positive
« Reply #3 on: May 02, 2011, 07:55:20 AM »
Hehe, this puzzled me for a while as well  ;D
Logged
iPod 5.5G 30GB, iPod nano 2G 8GB, 97% MPC and growing...
 

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Audio Playback, Database and Playlists
| | |-+  [Fixed] Replaygain: Small negative gain value displayed as positive
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.064 seconds with 15 queries.