Support and General Use > Theming and Appearance Customization

Sansa Clip+: RB default theme does not reset default viewport

(1/1)

HornetMaX:
Hi all,

I guess this is a bug: on a clip+ (or its UI simulator), use the recently posted "THE EXPANDER NOidBS" theme (http://themes.rockbox.org/index.php?themeid=1337&target=sansaclipplus). It has a line in its .cfg changing the default viewport to height 4, as:

--- Code: ---ui viewport: 0,4,-,-,1,-,-
--- End code ---

However, restoring the default RB theme after that, the default viewport (height = 8) is not restored and hence the default UI viewport interferes with the top status bar.

Worth an entry in Flyspray ?

MaX.

[Saint]:
(digging up a ghost of a thread)

Nope.

Any settings that one theme applies will be left in place if the next theme applied doesn't either apply an alternate value or reset the value to default.

This is expected (although somewhat confusing) behaviour.



[St.]

HornetMaX:

--- Quote from: [St.] on April 18, 2011, 02:09:26 AM ---(digging up a ghost of a thread)

Nope.

Any settings that one theme applies will be left in place if the next theme applied doesn't either apply an alternate value or reset the value to default.

This is expected (although somewhat confusing) behaviour.

--- End quote ---
The behaviour is fine, my point was more if or not the default theme (which is also the fallback one) should or not define the default viewport. I would say yes, as even in the wiki it is advised to always define the default viewport. Just a matter of modifying the default theme (no need to touch to the behaviour).

MaX.

Navigation

[0] Message Index