Support and General Use > Theming and Appearance Customization

WPS setting_inc not responding as expected

(1/1)

sugerfunk:
I have an Android phone -- the Samsung Galaxy S -- and I've been attempting to create a touchscreen theme that has a toggle switch for enabling/disabling EQ.  Since I use my phone both while I am traveling by train and in the car, I want to be able to take advantage of my car's EQ system, but I still want to listen through the graphic EQ via headphones.

So a toggle switch seems like a perfect solution.  I have already gotten the setting correctly configured, and I've been able to toggle using the following markup in the WPS:

%T(148,520,54,46,setting_inc,eq enabled)
%T(148,520,54,46,&setting_inc,eq enabled)

I have a graphic that displays when the settings is ON, and it displays and disappears exactly how it should every time I press it.  I also checked under the EQ menu settings, and it is making the change there as well (although it does not write the configuration change to disk so it is not there the next time I load Rockbox).

The main problem is, the change doesn't get reflected in the sound output.  I dug around in the code a little and I realize that there is a function called eq_apply() that gets called after any eq-related item changes in the menu.  I would suggest that any tone-altering setting change would trigger that function to be called -- but how would the code determine which settings would want to call that function and which ones wouldn't?  Also are there any other settings that require some kind of similar flush?  And is there any mechanism to make a setting "stick" (i.e. write to the main .cfg file) when altered via the WPS screen?  Perhaps setting_inc and setting_dec should trigger the entire corresponding menu item's code to fully unleash their potential?

Anyway, this is my first post, so I hope I'm not getting into something too specific for anyone to care.  I just thought I'd throw some observations/ideas out there and see what people thought.

JdGordon:
I'm not sure if you made this post or the flyspray task first, I replied there... bassically its unlikely this will be fixed.

Navigation

[0] Message Index