Rockbox Development > New Ports

Rockbox as an SDL app on the zipit Z2.

<< < (2/2)

JdGordon:

--- Quote from: dheyse on March 03, 2011, 10:16:05 AM ---I did a quick search in this forum for plugins, but didn't see much.  So I was wondering if anyone has done any work on keymaps for the SDL_PAD on the plugins. 

Also, is there any reason (other than the missing key mappings) that would prevent plugins from functioning on an SDL application build?

--- End quote ---

I read the logs and this isnt the best place to reply but will have to do. You shouldn't add SDL_PAD because it doesnt look like a really generic keypad. you should add a ZIPIT_PAD (or similar) because unless it is 100% egeneric it wont likely be used with other targets

dheyse:
Arrgh.  I just did something like a hundred SDL_PAD edits.  But you're right.  It seems like a generic SDL_PAD is a only good fit about 80% of the time.  Like when it's left, right, up, down, select, quit, and maybe menu.  I'll switch over to ZIPIT_Z2_PAD once I get it all to compile.

Meanwhile I found 2 files that should be fixed to separate HAVE_BUTTON_DATA from HAVE_TOUCHSCREEN.

In button.c lastdata should be declared when HAVE_BUTTON_DATA, not HAVE_TOUCHSCREEN, but it should require both defined when it's compared to data.

And button-sdl.c should be fixed to return *data unchanged when HAVE_BUTTON_DATA but not HAVE_TOUCHSCREEN.  Or hey, maybe it could return keyboard data.  I believe I saw something about a really old patch for that somewhere in the recent IRC logs. :)

Navigation

[0] Message Index

[*] Previous page