checkwps Segmentation fault and/or no errors listed

[Yotto]

I'm having trouble getting checkwps to work. I am running it on themes I downloaded using rbutil, and with themes that came with Rockbox.

I compiled my own 3.7.1 build from svn, and the build runs. The themes display perfectly and there are no problems there. The problem is that checkwps for 3.7.1 (which I created by running ./buildall.sh from the tools/checkwps/ directory) is not giving the output that I expect.

First off, I am running Rockbox on an iPod Video. I compiled Rockbox using option 22, Normal build. When I ran buildall.sh it created a file checkwps.mpiohd200 which I assume is correct for the ipod video though I have no reason except faith in buildall.sh.

When I run (from the tools/checkwps/ folder):

Code: [Select]

./checkwps.mpiohd200 /media/ROCKBOX/.rockbox/wps/cabbiev2.wps

I get:

Code: [Select]

Checking /media/ROCKBOX/.rockbox/wps/cabbiev2.wps...
WPS parsing failure
Segmentation fault

I downloaded (again via svn) the most recent build and compiled it, and then checkwps. It again created me a checkwps.mpiohd200 file which, when run in the exact same way as above does NOT get a Segmentation fault, but still fails:

Code: [Select]

Checking /media/ROCKBOX/.rockbox/wps/cabbiev2.wps...
WPS parsing failure

As I said, the cabbiev2 theme loads fine and displays as expected.

I get the same errors when I run checkwps on my own theme, which does NOT display properly and I don't know why. I was hoping to use checkwps to quickly find the problem but obviously that is not working, so I'm about to start trying to load it piece by piece into a simulator.

[[Saint]]

Perhaps you're not familiar with the target...but that is pretty obviously the checkwps for the MPIO HD200

You can build checkwps for your target just by running tools/configure as you would for building a binary for your player, but instead of selecting "Normal" (or letting it default to it) choose "Checkwps", then do "make" .


[St.]

[Yotto]

Well that was simple. I wish I'd seen the option when I compiled the first time. I'd likely have tried it.

Is there a purpose for the tools/checkwps directory then? This was so much simpler and quicker than that, and produced the correct file in an obvious way.

<EDIT>

Hmmm, scratch that. It found a couple errors but when I fixed those, I'm back to Segmentation Faults.

<EDIT>

I found what is causing the Segmentation Fault in the correct (thanks [St.]) checkwps program, it's the following bit of code:

Code: [Select]

%pb(-,12,16,297,10)

I know why it's wrong now that I see it. It should have been %pb(12,16,297,10).

[Chronon]

It might still be worth a bug report.  It seems to me that the program should fail gracefully rather than segfault.

[JdGordon]

i just tried that and it works as expected (with it trying load the filename '10' as the image :p ) are you sure it was that line?

[Yotto]

I'm sure. Here are the two files, before and after I fixed the problem. The "bad" one gets the segfault.

Also, I'm using the checkwps.ipodvideo from the daily build, which I compiled myself as described above from unmolested source.