Support and General Use > Theming and Appearance Customization
Help me debug my theme port!
audio-i:
--- Quote from: [St.] on January 17, 2011, 11:05:46 AM ---By the way...what makes you think I didn't test it?
--- End quote ---
--- Quote from: [St.] on January 16, 2011, 01:45:40 PM ---Without looking at the code for your theme...
[St.]
--- End quote ---
Plus the fact that you're still refusing to accept that the solution I posted, works.
--- Quote from: [St.] on January 17, 2011, 11:05:46 AM ---There's no point in fixing anything else if you're going to have overlapping textual viewports with scrolling text, if the text is absolutely static then sometimes you can get away with it...but it's bad practise to do so in general.
--- End quote ---
I agree that avoiding overlapping viewports is a good practice in general. But the solution I exposed makes it possible to display things right, even if there are overlapping viewports. That can be very useful if for some reason, e.g. to achieve a specific effect, you want to overlap viewports intentionally. Clearly from the original poster's last comment, that is not the case for him.
And as evilnick says, we agree on most of the things. Basically the theme needs a major cleanup (besides overlapping viewports, I found more issues, as I commented earlier)
[Saint]:
I went back and tested it after you called me out on it...I assumed that was obvious...perhaps not.
I am not *refusing* to believe anything, simply passing on my findings.
I cannot verify the %vf tag not being in the viewport definition causes any problems at all...*but it does not cause any on my device.
There is a HUGE difference between refusing to believe something, and finding different results from someone else.
My tests indicated to me that simply fixing the viewports was enough to get the theme to display correctly. Your earlier testing suggests differently...but that doesn't mean I refuse to believe it.
And yes, the theme has many other problems besides this one. I am only addressing the issue of the flickering viewports.
*EDIT: replaced "as" with the correct "but" to fix a slightly misleading/confusing line.
[St.]
audio-i:
Maybe just a couple misunderstandings on both sides caused the confusion (which is not good for the OP, that's all).
And as an example of this:
--- Quote from: audio-i on January 17, 2011, 11:46:18 AM ---... the solution I exposed makes it possible to display things right, even if there are overlapping viewports. That can be very useful if for some reason, e.g. to achieve a specific effect, you want to overlap viewports intentionally.
--- End quote ---
there is this theme http://themes.rockbox.org/index.php?themeid=1180&target=ipodcolor; if you put %Vf in a different line, the nice text effect given doesn't work, because he uses overlapping viewports.
DrewVosburg:
Seems like some theme testers are getting testy... =P
This is the first I've heard of themeeditor! I'll have to look into this. I've been making themes by hand and testing on-device for years, now I feel a bit silly not thinking to look for tools like this!
It would be nice if someone made a script to check for these types of semantic errors in the code, kind of like JSLint. That seems like a huge undertaking, but it would be really helpful for developers. Only problem I see is changes in syntax...
Throwing the idea out there in case someone has a lot of extra time on their hands.
[Saint]:
--- Quote from: audio-i on January 17, 2011, 12:05:37 PM ---there is this theme http://themes.rockbox.org/index.php?themeid=1180&target=ipodcolor; if you put %Vf in a different line, the nice text effect given doesn't work, because he uses overlapping viewports.
--- End quote ---
IIUC it should be perfectly possible to recreate the effect there without overlapping viewports.
If I get a chance later today (after sleeping, it's 6am) then I shall have a play with it.
I can't think of any reason where it would be necessary to deliberately overlap a viewport.
--- Quote from: DrewVosburg on January 17, 2011, 12:09:33 PM ---Seems like some theme testers are getting testy... =P
This is the first I've heard of themeeditor! I'll have to look into this. I've been making themes by hand and testing on-device for years, now I feel a bit silly not thinking to look for tools like this!
--- End quote ---
The theme editor was created by Robert Bieber with help from Jonathan Gordon (our skin guru) for the last Google Summer of Code (GSoC2010), at this point it is still a useful tool but it is quickly falling out of sync with the current syntax and misses many recently added tags.
It is useful, for cases like this, to be able to verify issues with viewports.
Personally, that's all I use it for...I find it quicker to code by hand still.
--- Quote from: DrewVosburg on January 17, 2011, 12:09:33 PM ---It would be nice if someone made a script to check for these types of semantic errors in the code, kind of like JSLint.
--- End quote ---
What types of errors are you talking about exactly?
Using %vf/b outside of a viewport definition line is not "incorrect", and any actual syntax errors will be picked up by checkwps when the author attempts to upload to the themesite.
A user can also compile checkwps themselves and run it on the theme to expose errors prior to uploading to the themesite, or just if their theme is broken and it is beyond their ability to parse the error manually.
There is also a script in the source that will update old skin syntax to new (though, it is not entirely foolproof, like many tools of it's kind).
[St.]
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version