Support and General Use > Theming and Appearance Customization

Help me debug my theme port!

(1/9) > >>

gbl08ma:
Hi!
I'm the author of the port of the theme photoSkins-green for iPod Nano (original is for iPod Video by Humberto Santana). It is available for download here: http://themes.rockbox.org/index.php?themeid=1241&target=ipodnano2g

It's already the second time I'm posting that theme - the first one had some glitches and was removed. Now that I already corrected most of these glitches (they had to do with the viewports), I'm still left with another. Here's what happens:

While on the WPS, the song title as well as the album, artist and playlist position disappear and appear again some seconds later. This isn't what it should do, it should scroll the text when it's too big to fit in the viewport.
To make things even more annoying, the texts don't disappear all at once: sometimes the title is visible but artist and playlist aren't, other times the playlist and artist are visible but the title or the album aren't visible... etc.

I thought it had something to do with the timings of scrolling and switching between showing the playlist position and the next track name, but I analysed the timing and conditionals code and it is equal on the two themes (the original and my port). Obviously, the viewports are smaller and in different positions because the screen is smaller too.

And to finalize, this phenomenon happens on my real iPod Nano 2nd Gen, but not on the iPod Nano 1G simulator! This makes the bug even harder to debug. I tried with the same music files, with the same IDv3 files. Only the file format was different (on my real device I have OGG and on the simulator I have MP3). Not that the files seems to matter much, because the problem exists on the real DAP with any of my 200 music files.

If anyone with an iPod Nano (1st or 2nd Gen) could download the theme and post what they see, it'd really appreciated. If someone has an idea so solve this problem, it'd be really great. If someone has a complete solution for this, it'd be wonderful :D

Regards
Gabriel

[Saint]:
gbl08ma,

Without looking at the code for your theme, this behaviour absolutely wreaks of overlapping viewports.

Opening the theme in the themeeditor will tell you very quickly if your use of viewports is less than sane.



[St.]

gbl08ma:
I used theme editor while porting the theme and it displays correctly in it.
Now I got to go out... see you tomorrow (GMT)

audio-i:

--- Quote from: [St.] on January 16, 2011, 01:45:40 PM ---Without looking at the code for your theme, this behaviour absolutely wreaks of overlapping viewports.

--- End quote ---
Sometimes it can be a really long shot to give advise without looking at the code  ;)

I got the initial version of the ported themes working on a friend's nano, and I remember that the specific problem gbl08ma is referring to, is because most or all of the viewports foreground colors (%Vf) were defined in a separate line, so correcting this should solve it.

gbl08ma, there were other problems, I don't really remember all of them, but some of them were bad placing of some things, the alternating routine that showed position in playlist and next track was wrong, that last line's text was cut at the bottom, and the bitmap strips for rewind and ffw were inaccurate, since there are three images, and the total height of the strip is 44, so it should be 45 or something divisible by 3, to avoid a weird effect . I'm attaching the version I did back then from your first upload... if you have the patience to compare it line by line to the current version you might identify all the issues I found back then, and see if they are not corrected yet in your new version. of course some things would have to be also replicated in the SBS. Hope it helps

Note to the admins: I guess .sbs and .fms didn't exist when the attachments to be allowed were defined, shouldn't they be added now?  ;)

[Saint]:

--- Quote from: audio-i on January 16, 2011, 07:59:36 PM ---Sometimes it can be a really long shot to give advise without looking at the code  ;)

--- End quote ---

From what he described, I immediately suspected overlapping viewports.

It's not just a few, but every textual viewport in the .wps that overlaps, it is quite obvious when viewed in the theme editor.

It is a classic symptom, and I have fixed countless themes for other authors to resolve this very problem.



--- Quote from: audio-i on January 16, 2011, 07:59:36 PM ---I got the initial version of the ported themes working on a friend's nano, and I remember that the specific problem gbl08ma is referring to, is because most or all of the viewports foreground colors (%Vf) were defined in a separate line, so correcting this should solve it.

--- End quote ---

No.

There has not been a need to place %vb/f() tags in the viewport definition for quite some time now, this is by design, so that one can easily change the colour of elements and not have it irrelevantly tied to the viewport definition.

It is perfectly fine to have them where they are in the code.



[St.]

Navigation

[0] Message Index

[#] Next page