Two features that should be removed from rockbox

[lionfury]

The feature on the the sudoku plugin where it tells you that you have made a wrong move should be taken off. The whole point of sudoku is to solve it and if you got something wrong to find out what it is. That feature pretty much ruins sudoku and makes it very easy to solve even the hardest puzzles

My second topic: mp3 encoder
This plugin is obviously unfinished and doesn't work so why is it included in the current build of rockbox?

[saratoga]

AFAIK the mp3 encoder works.

[lionfury]

AFAIK the mp3 encoder works.

I've tried it on all the settings and it always comes out sped up or with weird sounds. Once it even sounded like an alien spaceship! I don't know how it works for you.....

[saratoga]

AFAIK the mp3 encoder works.

I've tried it on all the settings and it always comes out sped up or with weird sounds. Once it even sounded like an alien spaceship! I don't know how it works for you.....

If theres not already an open bug report, then file one with details needed for someone to reproduce it. 

[AlexP]

The encoder used to work fine, if it is broken it needs fixing, not removing.

For sudoku, lots of sudoku programs have an option for this, and if ours doesn't then it should ideally be added.

[lionfury]

The encoder used to work fine, if it is broken it needs fixing, not removing.

For sudoku, lots of sudoku programs have an option for this, and if ours doesn't then it should ideally be added.

Try to use the encoder. The result is a shortened and messed up file. Mos of the outputs I got don't even sound simailer to the original
Link to the flyspray post:
http://www.rockbox.org/tracker/10678

[saratoga]

The encoder used to work fine, if it is broken it needs fixing, not removing.

For sudoku, lots of sudoku programs have an option for this, and if ours doesn't then it should ideally be added.

Try to use the encoder. The result is a shortened and messed up file. Mos of the outputs I got don't even sound simailer to the original
Link to the flyspray post:
http://www.rockbox.org/tracker/10678

According to that post the problem is that the encoder doesn't work if you set the sample rate to 24kHz.  Thats a lot different then "doesn't work". 

[AlexP]

The encoder used to work fine, if it is broken it needs fixing, not removing.

For sudoku, lots of sudoku programs have an option for this, and if ours doesn't then it should ideally be added.

Try to use the encoder. The result is a shortened and messed up file. Mos of the outputs I got don't even sound simailer to the original
Link to the flyspray post:
http://www.rockbox.org/tracker/10678

I said it used to work, which it did.

[yapper]

I think Saratoga's comment was aimed at the OP:

My second topic: mp3 encoder
This plugin is obviously unfinished and doesn't work so why is it included in the current build of rockbox?

[GGGGGG]

The mp3 encoder works just fine for me.

[AlexP]

Yes, because:

According to that post the problem is that the encoder doesn't work if you set the sample rate to 24kHz.  Thats a lot different then "doesn't work". 

[pixelma]

Late reply but I don't fully understand this:

The feature on the the sudoku plugin where it tells you that you have made a wrong move should be taken off. The whole point of sudoku is to solve it and if you got something wrong to find out what it is. That feature pretty much ruins sudoku and makes it very easy to solve even the hardest puzzles

As far as I have seen, it only tells you about a wrong move if you already break the rules with everything filled before. It does not prevent you from making a mistake if it doesn't conflict already - it's not like it only accepts the one correct number. This is also how a lot of sudoku games I saw on PC or e.g. phones work. I admit it would be nice if there was an option to turn it off but then it needs another notification when finished correctly.

No-one would hold anyone back implementing this but it's not as "dramatic" as you tell it is in my eyes and someone has to do the work....