Weird bug with %Rp and %tp and iPod Video

[[Saint]]

Ok guys, it's "weird stuff time"...


I've found an odd bug with the %Rp and %tp tags in current SVN that only seems to appear on the iPod Video for some reason.

The same code that fails on the iPod Video simulator (also tested on device, thanks LambdaCalculus37 ) works fine on Nano 1st and 2nd Gen (both sim and device)...

I have no idea how that is even possible, it took me a very long time to realise that it was the build at fault and not the skin code...I spent ages trying to find bugs in my code that weren't actually there.

I just thought it was safer to assume that it was my code at fault.

Anyway, here's the code:

Code: [Select]

# PLAYMODE ICON[S]
#
%Vl(b,11,4,18,15,-)%Vf(000000)%Vb(FFFFFF)
#%?mp<|%xd(Da)|%xd(Db)|%xd(Dc)|%xd(Dd)|%?Rp<%xd(Da)>|%?Rp<%xd(Db)>|%?tp<%xd(Da)>|%?tp<%xd(Db)>>
#
%?mp<|%xd(Da)|%xd(Db)|%xd(Dc)|%xd(Dd)|%xd(Da)|%xd(Db)|%xd(Da)|%xd(Db)>
#
# STATUS/TITLE BAR ["IPOD" & 12/24 HOUR CLOCK]
#
%V(50,4,220,18,2)%Vf(000000)%Vb(FFFFFF)
#%s%ac%t(10.0)%?bp<%?bc<Charging|Charged>|%?cs<iPod||%?Rp<%Sx(Recording)>|%?tp<%Sx(FM Radio)>|%Sx(Playlist)>>;%t(10.0)%ac%?cf<%cH:%cM|%cl:%cM %cP>
#
%s%ac%t(10.0)%?bp<%?bc<Charging|Charged>|%?cs<iPod||%Sx(Recording)|%Sx(FM Radio)|%Sx(Playlist)>>;%t(10.0)%ac%?cf<%cH:%cM|%cl:%cM %cP>

The two failing lines are commented, and the corrected (working on iPod Video) lines immediately below.

If anyone could help me with this, I would greatly appreciate it...it is most certainly beyond my expertise as it isn't something I can't code my way out of with skin code.
This is something freaky happening in core.

The full theme is available for download here



Thanks in advance,

[St.]

[JdGordon]

failing how?

[[Saint]]

failing how?

Errrrr....not working?

The .sbs is rejected, and won't load. Try it, grab a current sim and the attached theme.




[St.]

[JdGordon]

fixed.you should have tried uploading to the theme site.... checkwps gave me the perfect output to figure it out

Code: [Select]

Starting program: /home/jonno/rockbox-git/video-sim/checkwps.ipodvideo simdisk/.rockbox/wps/iLike.sbs
Checking simdisk/.rockbox/wps/iLike.sbs...
WPS parsing failure
Error on line 2.
%?mp<...Rp<%xd(Da)>|%?Rp<%xd(Db)>|%?tp<%xd(Da)>|%?tp<%xd(Db)>>
                  ^ 'Expected argument seperator' Here