Need a second person to look at my .wps

[trasman]

Hi.
I need some help finding the problem whit this .wps

This is the original .wps that was working alright with rockbox 3.6 ipod video 64GB.

# Credit for the starting layout is to Steven Kang
# http://www.rockbox.org/twiki/bin/view/Main/WpsIriverH100#StevenKang
# Credit for the title/album/artist logic is from Jens Arnold
# http://www.rockbox.org/twiki/bin/view/Main/WpsArchos#JensArnold
# I originaly made this for the iRiver H1x0 and convertied it with
# new stuff added to the iPod Video
# Made by Peter Olson
# Edit by Sajmån Dajmånd
%wd
%al%ca %cd %?cm<Jan|Feb|Mar|Apr|Maj|Jun|Jul|Aug|Sep|Okt|Nov|Dec> %cY %cH:%cM %arVol:%pvdB
%alBat:%bt %ar[%pp/%pe]
%ac%?mp<Stop|Play|Pause|Ffwd|Rew> %ar%?lh<HDD|>

%s%ac%?ia<%ia|.. %?d2<%d2|%?d1<(Root)|>>>
%s%ac%?id<%id|. %?d1<%d1|(Root)>>%?iy< (%iy)|>
%s%ac%?it<%?in<%in. |>%it|%fn>
%al%pc/%pt %ar-%pr
%pb
%ac%?fc<MP1|MP2|MP3|AIFF|WAVE|OGG|FLAC|MPC|AC3|WavPack|alac|aac|SHN|SID|ADX|NSF|speex|SPC|APE|WMA|unknown> %?fv<VBR|CBR> %fbkbps %fkKHz %fsKb
%pm
%ac%?ps<Shuffle|>%?mm<|All |One |Shuffle |A-B >%?mh<Hold|>
%ar%?bs<--Time Left %bs--|> %ac%?bp<%bp %bc|>
%acNEXT SONG
%ac%?Ia<%Ia|.. %?D2<%D2|%?D1<(Root)|>>>
%ac%?Id<%Id|. %?D1<%D1|(Root)>>%?Iy< (%Iy)|>
%ac%?It<%?In<%In. |>%It|%Fn>

And this is the one I modifies to use with 3.7 following the new SkinBreakingChange found Here. (Changes in bold)

# Credit for the starting layout is to Steven Kang
# http://www.rockbox.org/twiki/bin/view/Main/WpsIriverH100#StevenKang
# Credit for the title/album/artist logic is from Jens Arnold
# http://www.rockbox.org/twiki/bin/view/Main/WpsArchos#JensArnold
# I originaly made this for the iRiver H1x0 and convertied it with
# new stuff added to the iPod Video
# Made by Peter Olson
# Edit by Sajmån Dajmånd
%wd
%al%ca %cd %?cm<Jan|Feb|Mar|Apr|Maj|Jun|Jul|Aug|Sep|Okt|Nov|Dec> %cY %cH:%cM %arVol:%pvdB
%alBat:%bt %ar[%pp/%pe]
%ac%?mp<Stop|Play|Pause|Ffwd|Rew> %ar%?lh<HDD|>

%s%ac%?ia<%ia|.. %?d(2)<%d(2)|%?d(1)<(Root)|>>>
%s%ac%?id<%id|. %?d(1)<%d(1)|(Root)>>%?iy< %(%iy%)|>
%s%ac%?it<%?in<%in. |>%it|%fn>
%al%pc/%pt %ar-%pr
%pb
%ac%?fc<MP1|MP2|MP3|AIFF|WAVE|OGG|FLAC|MPC|AC3|WavPack|alac|aac|SHN|SID|ADX|NSF|speex|SPC|APE|WMA|unknown> %?fv<VBR|CBR> %fbkbps %fkKHz %fsKb
%pm
%ac%?ps<Shuffle|>%?mm<|All |One |Shuffle |A-B >%?mh<Hold|>
%ar%?bs<--Time Left %bs--|> %ac%?bp<%bp %bc|>
%acNEXT SONG
%ac%?Ia<%Ia|.. %?D(2)<%D(2)|%?D(1)<(Root)|>>>
%ac%?Id<%Id|. %?D(1)<%D(1)|(Root)>>%?Iy< %(%Iy%)|>
%ac%?It<%?In<%In. |>%It|%Fn>

Still after this changes the playback screen locks messed up. Can someone find the problem course I can't?

[biengo]

Well, at least one viewport needs to be added for the progress bar.

Code: [Select]

%V(x,y,width,hight,-)%Vf(22f100)%Vb(000000)
%pb

Also, you need to create another viewport for your text to appear in. See http://www.rockbox.org/wiki/CustomWPS#Viewports

[trasman]

So I managed to isolate the troublesome code

%s%ac%?ia<%ia|.. %?d2<%d2|%?d1<(Root)|>>>
%s%ac%?id<%id|. %?d1<%d1|(Root)>>%?iy< (%iy)|>

Any ides on how to make it 3.7 compatible?

[sockbox]

escape your parentheses...

Code: [Select]

%(ROOT%)

[pixelma]

So I managed to isolate the troublesome code

%s%ac%?ia<%ia|.. %?d2<%d2|%?d1<(Root)|>>>
%s%ac%?id<%id|. %?d1<%d1|(Root)>>%?iy< (%iy)|>

The same as you did with the year info. If you want to display parentheses in the WPS they need to be escaped. Don't forget to use the directory level tags with them though as you alredy seem to do, following your first post.

%ac%?Ia<%Ia|.. %?D(2)<%D(2)|%?D(1)<%(Root%)|>>>
%ac%?Id<%Id|. %?D(1)<%D(1)|%(Root%)>>%?Iy< %(%Iy%)|>

My main wish to post here was to add something about biengo's suggestion.

As far as I know putting the progressbar into an own viewport is not necessary as long as everything is in the default viewport (or in other words: no viewport definitions are used at all). I admit not being a 100% sure about that, will try to get back later with confirmed info. EDIT: I talked to the main developer behind the latest theme changes and he confirmed.

But one thing I am sure about: you suggest values for %Vf and %Vb - I'd like to point out that this is (a) not always needed, you can leave it out if you just want to use the global set foreground or background colours. And (b) the values you suggest would be wrong on targets with greyscale displays (which use numbers for the 4 grey shades, not RGB) and would be completely ignored on targets with monochrome displays. Please be careful with information.

[trasman]

Finally , after some troubleshooting and with a BIG help from you folks, I manage to get it working. (:

Thank you so much!

[rbhawaii]

could i try your WPS on my ipod video? could you post the corrected code please? and the font needed? thanks