Thank You for your continued support and contributions!
My thinking is a current directory static filenames setup is probably the fastest way as there's no id3-> tag compares just an if. Something obvious like .rbaa<size>.bmp. Yes? Is it worth the #1 search position in albumart.c? Would the speed increase be noticeable to human eyes?
Sidenote, since ID3 tags in flacs is considered wrong, from my newbieness with the code it looks like flac metadata is being parsed properly and just stored in variables labelled for ID3? It's kind of confusing.
We already support that. Take a look at the album art wiki page. If you don't want to decode/resize at playback you can do it in advance.
This is probably not the reason behind the problem you are having, in summary. When you say "lag", what do you mean? Between the track starting and the album art appearing on the WPS, or something else? Does the audio keeps playing fine, or does that stop too?
Originally Rockbox only supported MP3 playback, because it ran on a device with hardware MP3 decoding. Thus, the metadata system was originally written just for ID3, and when it was extended to support other metadata formats the names were left alone.
Yep. Not from the wiki page but from the bool search_albumart_files stack of if conditionals. I was thinking that, considering we're talking about 200MHz ARM9 in a Telechips IC, even such simple things might contribute milliseconds here and milliseconds there, just want to make it instantaneous if possible.
I'm stuck, you cannot make a : part of a filename on a FAT32 filesystem. This will need to be changed. Should I file a bug report?
Rb's kernel is that efficient? Hallelujah!
I was trying to do some quick speed testing by renaming all Folder.jpg & cover.jpg files and converted them all to .rockbox/albumart/<artist>-<albumname>:<size>.bmp, but uh, I'm stuck, you cannot make a : part of a filename on a FAT32 filesystem. This will need to be changed. Should I file a bug report?
hmm...my manual says:5. /.rockbox/albumart/albumartist-albumtitle.{jpeg,jpg,bmp} why not just rename all your large AA as folder.jpg then create the small versions as cover.bmp which is supposed to be higher in the search order.
No. Reading the relevant part of the manual should be sufficient.
Quote from: gevaerts on September 29, 2010, 02:53:26 PMNo. Reading the relevant part of the manual should be sufficient.Could you please explain this code block from from albumart.c ?
I did not make this up, nor write this code, and since the whole point is to lessen the compare interval to it's shortest time possible thought it relevant that it skip the per-file search...
since the whole point is to lessen the compare interval to it's shortest time possible thought it relevant that it skip the per-file search..
Its a comment that lists all the places album art can be searched, same as the ones in the manual. Actually looking at it none of them have the colon in it you mentioned above, nor do the wiki or manual. Where the heck did you get the idea you needed a colon? It should probably be fixed.
Page created in 0.119 seconds with 21 queries.