Rockbox Development > Feature Ideas
faster AA?
CowonFTW:
Rb's kernel is that efficient? Hallelujah!
Hmm. OK.
I was trying to do some quick speed testing by renaming all Folder.jpg & cover.jpg files and converted them all to .rockbox/albumart/<artist>-<albumname>:<size>.bmp, but uh, I'm stuck, you cannot make a : part of a filename on a FAT32 filesystem. This will need to be changed. Should I file a bug report?
gevaerts:
--- Quote from: CowonFTW on September 29, 2010, 02:45:31 PM ---I'm stuck, you cannot make a : part of a filename on a FAT32 filesystem. This will need to be changed. Should I file a bug report?
--- End quote ---
No. Reading the relevant part of the manual should be sufficient.
jimbilly:
hmm...
my manual says:
5. /.rockbox/albumart/albumartist-albumtitle.{jpeg,jpg,bmp}
why not just rename all your large AA as folder.jpg then create the small versions as cover.bmp which is supposed to be higher in the search order.
saratoga:
--- Quote from: CowonFTW on September 29, 2010, 02:45:31 PM ---Rb's kernel is that efficient? Hallelujah!
--- End quote ---
Branches are handed by the decode logic on the processor, not by software. Rockbox doesn't have efficient branches, it runs on processors that only take a few cycles to compute a branch.
In other words branches are quick because your processor is simple, and simple processors have fast branches.
--- Quote from: CowonFTW on September 29, 2010, 02:45:31 PM ---I was trying to do some quick speed testing by renaming all Folder.jpg & cover.jpg files and converted them all to .rockbox/albumart/<artist>-<albumname>:<size>.bmp, but uh, I'm stuck, you cannot make a : part of a filename on a FAT32 filesystem. This will need to be changed. Should I file a bug report?
--- End quote ---
http://download.rockbox.org/daily/manual/rockbox-sansafuzev2/rockbox-buildap2.html#x17-374000B.20
CowonFTW:
--- Quote from: jimbilly on September 29, 2010, 02:54:17 PM ---hmm...
my manual says:
5. /.rockbox/albumart/albumartist-albumtitle.{jpeg,jpg,bmp}
why not just rename all your large AA as folder.jpg then create the small versions as cover.bmp which is supposed to be higher in the search order.
--- End quote ---
No, that's unacceptable. Rockbox must co-exist properly with both the host machines and the player's stock firmware. Both Folder.jpg and cover.jpg will remain.
--- Quote from: gevaerts on September 29, 2010, 02:53:26 PM ---No. Reading the relevant part of the manual should be sufficient.
--- End quote ---
Could you please explain this code block from from albumart.c ?
/* Look for the first matching album art bitmap in the following list:
* ./<trackname><size>.{jpeg,jpg,bmp}
* ./<albumname><size>.{jpeg,jpg,bmp}
* ./cover<size>.bmp
* ../<albumname><size>.{jpeg,jpg,bmp}
* ../cover<size>.{jpeg,jpg,bmp}
* ROCKBOX_DIR/albumart/<artist>-<albumname><size>.{jpeg,jpg,bmp}
* <size> is the value of the size_string parameter, <trackname> and
* <albumname> are read from the ID3 metadata.
* If a matching bitmap is found, its filename is stored in buf.
* Return value is true if a bitmap was found, false otherwise.
*
* If the first symbol in size_string is a colon (e.g. ":100x100")
* then the colon is skipped ("100x100" will be used) and the track
* specific image (./<trackname><size>.bmp) is tried last instead of first.
*/
And most specifically:
if (*size_string == ':')
{
size_string++;
track_first = 0;
I did not make this up, nor write this code, and since the whole point is to lessen the compare interval to it's shortest time possible thought it relevant that it skip the per-file search...
Thanks for reading.
edit: mouth too big
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version