Rockbox Development > Feature Ideas
config per directory?
saratoga:
I'm not a fan of having per folder config files. Its a nice enough idea in principle, but it would complicate buffering/playback and only be useful for a small number of cases.
oayz:
Why would it affect buffering/playback? It's similar to reading album art, isn't it?
Yes, it may have a little use for some of us but will enhance flexibility by a lot. Even 2 most useful options - equlizer and shuffle should make this feature worthwhile. People who listen to books and music whould definetly appreciate having 2 set of settings (which they probably already have) and not having manually switch them.
Unless this feature interferes with main functionality why not have it? It's transparent, seems to easy to implement, consistent with current behavior and doesn't require much code.
saratoga:
--- Quote from: oayz on September 08, 2010, 05:14:05 PM ---Why would it affect buffering/playback? It's similar to reading album art, isn't it?
--- End quote ---
Reading album art required quite a lot of changes to buffering and playback that are still being worked on.
--- Quote from: oayz on September 08, 2010, 05:14:05 PM ---Unless this feature interferes with main functionality why not have it? It's transparent, seems to easy to implement, consistent with current behavior and doesn't require much code.
--- End quote ---
Well if its transparent, easy to implement and won't require changing much, I might be persuaded with an elegant enough implementation. Feel free to post your code for review.
oayz:
You've got me on this. I'll rest my case - enough is said already.
Here is pseudo code (sorry this is the best I can do):
On boot:
current_cfg = /.rockbox/default.cfg
On user config load:
current_cfg = user.cfg
On each directory change:
if "local.cfg" file is present
local_cfg = "local.cfg" // apply local settings
read/parse/apply "local_cfg"
elseif local_cfg != current_cfg
local_cfg = current_cfg // apply global settings
read/parse/apply "local_cfg"
end
Note: read/parse/apply operates the same way as user loading new config via configuration menu.
torne:
The point is that we don't read one track at a time, we read as many as will fit into memory, so you can't just look for the config file and load it immediately; you would need to look for the config files that correspond to *future* tracks on the playlist and load their contents without applying the settings, and leave them somewhere so you can apply them at the appropriate time later. This is what we mean by changes to buffering and playback.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version