ACTION_TREE_STOP should stop radio too?

[Confuseling]

Would it make the UI more consistent if ACTION_TREE_STOP, which as best I can tell just means 'stop playing music whilst in a menu', and seems to ultimately call 'list_stop_handler' in apps/misc.c, stopped the radio as well as any local file which might be playing?

ETA- To clarify slightly, it just seems strange that if you drop out of the WPS into a menu, then hit a key assigned to ACTION_TREE_STOP, it stops, whereas if you drop out of the Radio screen and do the same, it ignores you.

I had a look at patching this myself, but there seems to be too much separation between radio.c and the general interface handling code for a non-coder to deal with...

[JdGordon]

that last sentance is very likely why it doesnt work.

radio.c is mostly very old code which has been kept up to date with kludges and hacks. Alot of that code shouldnt even be in apps at all. So if someone were to clean that mess up it should be simple enough to fix, (actually isnt there a radio_stop() ? )

[Confuseling]

There is a radio_stop(), and I tried adding that to list_stop_handler, and adding the radio.h to the includes of misc.c, but it didn't do anything (understandably).

I have no experience of working with multiple file programs - barely any programming experience at all, so that's where I stopped digging. I suspect I could make it work by pulling various functions out of radio.c and so forth and sticking them in misc.c, but it would be a supreme fudge...

[JdGordon]

hmm! no that should work

[Confuseling]

I probably fluffed it up - that's no surprise.

I'll have another go later, unless you get there first (feel free! 

ETA -

Ha! You were right, it does work. Not sure if this is how it's supposed to be written, but hey...

http://www.rockbox.org/tracker/task/11606

Thanks.