Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Conditionals with timings
« previous next »
  • Print
Pages: 1 [2]

Author Topic: Conditionals with timings  (Read 5971 times)

Offline AsusFreak

  • Member
  • *
  • Posts: 64
Re: Conditionals with timings
« Reply #15 on: August 31, 2010, 07:17:40 AM »
JdGordon,
I saw you released r27956 to solve this problem (?). I tried it with my AF_Black theme and still have the same problem. I used the following line to get something like an Onscreen Menu disappearing after 2 seconds:

Code: [Select]
%?St(touchscreen mode)<%?Tl(2)<%Vd(j)|%Vd(k)>|%Vd(k)>

It does disappear but the refresh of the rest does not work and I pointed out that because of the timing in the conditional I never get back to the redrawing Viewport - only by re-pressing the screen the conditional works right again because it starts at a defined status.

I tested this with an old release r27530 and everything's working fine.

@ew:
Please name the bug number here, then I will add my part.
« Last Edit: August 31, 2010, 07:20:42 AM by AsusFreak »
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Conditionals with timings
« Reply #16 on: August 31, 2010, 08:43:09 AM »
read the thread, that commit didnt actually fix this issue, and that line has no timeout tags in which means means it is a ocmpletly different issue
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline ew

  • Member
  • *
  • Posts: 52
Re: Conditionals with timings
« Reply #17 on: August 31, 2010, 09:11:19 AM »
FS#11588 filed (http://www.rockbox.org/tracker/task/11588) for this item.

Thanks,

EW
Logged

Offline AsusFreak

  • Member
  • *
  • Posts: 64
Re: Conditionals with timings
« Reply #18 on: August 31, 2010, 09:24:44 AM »
Quote from: JdGordon on August 31, 2010, 08:43:09 AM
read the thread, that commit didnt actually fix this issue, and that line has no timeout tags in which means means it is a ocmpletly different issue

Completely different? Conditional with a timeout. It might be a different tag but for me as user (with less coding skills than you) I understood it as a possible identical issue. If I'm wrong I'm sorry.

Quote from: Wiki

If you put a number straight after %Tl it will be used as a timeout in seconds (e.g %Tl2.5 will give a 2.5s timeout) between the touchscreen press being released and the tag going false. If no number is specified it will use a 1 second timeout. Can also be used as a conditional, and can be used with conditional viewports for some really neat effects.

« Last Edit: August 31, 2010, 09:28:26 AM by AsusFreak »
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Conditionals with timings
« Reply #19 on: August 31, 2010, 09:29:27 AM »
different tag, completly different issue
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline AsusFreak

  • Member
  • *
  • Posts: 64
Re: Conditionals with timings
« Reply #20 on: August 31, 2010, 09:31:09 AM »
Ok, than I AM sorry. :-[
Logged

Offline ew

  • Member
  • *
  • Posts: 52
Re: Conditionals with timings
« Reply #21 on: September 03, 2010, 02:59:20 PM »
Forgive me if I am dense, but I saw that the bug was resolve and a fix was checked in, but I don't see how the problem is solved.

The following are the results of my testing of r27994 (I had to wait for a simulator build).

Again, my wps code is:

Quote
%?ic<%s%al%t(6)Composer:|%t(0)>;%?iA<%s%al%t(6)Alb Artist:|%t(0)>;%?ia<%s%al%t(6)Trk Artist:|%t(0)>
%?ic<%s%al%t(6)%ic|%t(0)>;%?iA<%s%al%t(6)%iA|%t(0)>;%?ia<%s%al%t(6)%ia|%t(0)>

I have a track that has an %iA, but no %ia or %ic

As a result of the first line of the wps, I get a short display of "Alb Artist:" with a longer display of a blank line.  I would think that there should not be any blank display.
The second line continues to display the contents of the %iA tag - and begins the scroll process about each two seconds.  If the tags are blank is the prior tag value not being cleared out?

Additionally, if I changed some (or all) of the %t(6)s on the first line to %t(9)s (changed from 6 seconds to 9 seconds) the synchronization between the first and the second line does not change.  Furthermore, each conditional subline seems to be occurring after about 2 seconds, and not the time specified in the %t tag.

Just as another informational point, after the fix, the following sbs line caused a fault in both the player and the simulator

Quote
%?bc<%t(0.1)%xd(Ba)|%t(0)>;%?bc<%t(0.1)%xd(Bb)|%t(0)>;%?bc<%t(0.1)%xd(Bc)|%t(0)>;%?bc<%t(0.1)%xd(Bd)|>

In truth, this was a very stupid line, and I was able to change the line, get the same effect, simplify the code and avoid the fault by using the following as a substitute

Quote
%?bc<%t(0.1)%xd(Ba);%t(0.1)%xd(Bb);%t(0.1)%xd(Bc);%t(0.1)%xd(Bd)|>

The only reason that I mention this is that you may want to avoid situations where theme code produces a device fault.

I would be glad to do some more testing, but at the current time, my build environment is broken and I have no idea how to fix it (I have another thread on this).

Thanks for all the assistance.

I think It does not appear that the sub-lines that
Logged

Offline ew

  • Member
  • *
  • Posts: 52
Re: Conditionals with timings
« Reply #22 on: October 12, 2010, 10:20:47 AM »
Been out of touch for a little while, but I am able to confirm that as of build 28235, the issue seems to be fixed.  Perhaps it was fixed in 28226, or some other build, nonetheless it seems to be working now.

Thank you!
Logged

  • Print
Pages: 1 [2]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Conditionals with timings
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.074 seconds with 14 queries.