Support and General Use > Theming and Appearance Customization

viewport labels allow real names now (do the same for images?)

<< < (2/3) > >>

[Saint]:
I've been thinking it and thinking it, and just have to really say it...

This seems like throwing out an idea that works fine, for an idea that will just end up complicating things.

I'd really love to know the percentage of users that voted "yes, and dont bother keeping the old %xd(Aa) type tag" that actually theme Rockbox.

Is:


--- Code: ---"%xd(animation, %xx(<timeout>, <max count>))"
--- End code ---

*really* any better than what we have now...which is perfectly usable, and readable in my opinion.
(remember, there might be an additional offset value in there too somewhere...)

If you can guarantee that the tag has no less states than the bitmapstrip it is assigned to has subimages, and that you only want to use said images in the exact order as dictated by the layout of the subimages, then this works....but it seems like a terribly specific, and limited use case to me.

(example: What if you wanted a different timeout for just one image even? This code can't help there and you need to do it the 'original' way)


[St.]

Llorean:
Neither jdgordon nor I suggested anything that includes a "timeout" value. It's pretty clear you're misunderstanding what is being suggested here. This isn't time based at all, and time is only involved in the one instance I suggested where the time is not a timeout, but the frequency at which a user pushes a button and the rate of playback of the song.

If you want to complain about the idea, take the time to understand it first. If you don't get what I'm suggesting, I can try to explain it again more clearly, but I need to know what you think I suggested first. What do you think is being described exactly?

seani:
On the face of it, useful, but two questions:


What is the cost in terms of binsize?


Wouldn't it be better to abstract this sort of syntactic sugar out and just put more effort into hiding these details behind the theme builder?

Your resources are essentially unlimited on the Linux  / Windows client end.


Surely you'd hope that the fine art of hand-crafting a theme would slowly become redundant as the theme editor became more refined?


Give that's the case, why sacrifice any size / performance for readability of the raw theme file?

[Saint]:
Llorean,


You read Jd's posts...right?

I did.

--- Quote from: JdGordon on August 02, 2010, 10:23:32 AM ---well, right now we dont have a tag which just counts, animations are done with sublines but if a counter tag was added I tihnk we could make that work here also... %xd(animation, %xx(<timeout>, <max count>)) no need for mod at all.

--- End quote ---

Llorean:
Yes, and if you read the whole thread, he posted that in response to a misunderstanding about my post - that is, he didn't suggest a timeout, but he thought I did and was disagreeing with it. Since I didn't, his point there was pretty irrelevant.

Sure, cherry picking one post in which the author also missed the suggested idea can work in your favor, but the point is the original idea and my suggestion both don't include the idea of a timeout, so nobody was arguing for it at the point you started arguing against it.

Navigation

[0] Message Index

[#] Next page

[*] Previous page