Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Rockbox Ports are now being developed for various digital audio players!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Missing Theme
« previous next »
  • Print
Pages: [1]

Author Topic: Missing Theme  (Read 1853 times)

Offline Avalon

  • Member
  • *
  • Posts: 88
Missing Theme
« on: July 30, 2010, 11:38:57 AM »
Hi,

I have uploaded a couple of themes which have been listed for weeks since the recent syntax changes and 3.6 release. 

Recently, the theme FuzeRock+ for the Fuze is not listed.

Could you indicate why?

Thks
Logged

Offline Progweed

  • Member
  • *
  • Posts: 67
Re: Missing Theme
« Reply #1 on: August 01, 2010, 06:13:54 AM »
I'd like to know that as well. I recently uploaded three themes ("CabbieV2++", "Keep it simple, stupid" default & dark) and they are all gone.

It's a shame, as some people seemed to like them.

If I made mistake or if something is wrong with my themes I'm of course more than willing to fix them ASAP.
Logged

Offline Avalon

  • Member
  • *
  • Posts: 88
Re: Missing Theme
« Reply #2 on: August 01, 2010, 08:15:20 AM »
I had a closer look at the FuzeRock+ and found that some of the code that was previously accepted by the Theme checking software is now rejected.

I do not know the reason for this, since the theme worked for 3.6 with the new syntax and many people were using it.  It also worked fine in the simulator.

I spent a little time tracking down the code that was rejected and found that a reference to (root) appeared to be the problem.  I removed this and resubmitted.  It was accepted.

I suspect that since the syntax change, the theme checker has been upgraded more then once.  When you submit a theme, it does indicate the offending lines which is a great help in tracking down the problem.

I am not a developer, so my comments are really just observations.

Hope this helps.
Logged

Offline Progweed

  • Member
  • *
  • Posts: 67
Re: Missing Theme
« Reply #3 on: August 01, 2010, 12:21:26 PM »
That helped a lot, thank you very much. You were right about the recent changes in the theme checker.
Logged

Offline pixelma

  • Rockbox Expert
  • Member
  • *
  • Posts: 645
Re: Missing Theme
« Reply #4 on: August 01, 2010, 12:39:31 PM »
Quote from: Avalon on August 01, 2010, 08:15:20 AM
I spent a little time tracking down the code that was rejected and found that a reference to (root) appeared to be the problem.  I removed this and resubmitted.  It was accepted.

If the theme should literally display
Quote
(root)
on the display, you probably now have to code it differently, "escaping" the ()s.

With the new parser () got a "meaning" in the WPS tags, if you want to display these characters, you need to write %( or %) so that the parser knows "just display them". This is similar to %% and %| to display percent sign or pipe which has been there since ages.

The example becomes
Code: [Select]
%(root%)
Logged

Offline Progweed

  • Member
  • *
  • Posts: 67
Re: Missing Theme
« Reply #5 on: August 01, 2010, 12:54:47 PM »
Great, I was about to ask why this little snippet of code doesn't work anymore:

Code: [Select]
%?iy<(%iy)>

But you already answered that.  ;D
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Missing Theme
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.072 seconds with 14 queries.