How do I persuade developers to add my plugin to Rockbox?

[danr]

Hi,

A while back I developed a plugin for Rockbox called Shopper, which allows you to create a re-usable shopping list.  I find it handy to walk around the kitchen with my media player and tick off what's needed each week.

I submitted a patch back in November but it seems like nobody has taken a look at it so far.  What's the general procedure for getting a patch like this added to Rockbox?

The patch was created against the version at the time, I think that was version 3.4, but it's straightforward to view the contents of the patch and manually edit the three or so files which are affected.  I tried this using the latest source from a few days ago.

If you want to take a look, you can find my patch here:http://www.rockbox.org/tracker/task/10820

Regards,
Dan

[funman]

The best method I know is go on the irc channel and get a developer interested so he can look at it and commit it.

[danr]

Thanks, I've asked on irc so we'll see if anything happens.

BTW kudos to you funman for all your work on the Sansa ports.

[AlexP]

We are aware that we have a bit of an issue with patch rot - best way is just to keep bugging us on IRC

First comment: a manual patch to go along with the plugin would be very welcome. 

I haven't looked at the patch, but if they aren't already there, keymaps for other targets are a good thing - for something this simple I'd imagine that the plugin lib actions are ideal.  Also, make sure you are following http://svn.rockbox.org/viewvc.cgi/trunk/docs/CONTRIBUTING?view=markup for the best chance of someone doing something

[danr]

I still haven't heard anything so I think I will have to go on IRC again  .  All a bit frustrating really.

I don't mind making changes to the patch as necessary, but I don't think there's much point unless someone says there's a chance they'll apply the patch once I've done it  .

[torne]

If it works on the majority of targets (ideally all targets it could possibly work on), it's not implemented in a way which is obviously sucky and wrong, it's appropriately licensed and you have given us your real name then it will be committed, if someone has enough time to check that the aforementioned things are true.

Sorry if we don't give all issues enough attention; a lot of patches *aren't* in a suitable state to be committed, so sometimes the ones that are don't get noticed. Bug us on IRC again

[danr]

Yay, one of the developers reviewed my plugin over the weekend.  He asked me to make some cosmetic changes and a few checks in a file loading routine, so I've submitted a tidied-up version.

We'll see what develops 

[danr]

If anyone's interested, Shopper was committed to Subversion today, so should be available to everyone from tomorrow