Support and General Use > Theming and Appearance Customization

Theme Editor Feedback

<< < (2/8) > >>

yzflcyq:
Found a bug:

--- Code: ---%V(4,242,232,20,2)%Vf(a4c0e4)
%s%ac%?id<%id%?iy<(%iy)>|%?iy<Year:%iy|--->>
--- End code ---

I wrote this in order to show like:

--- Quote ---Air OST(Year:2002)
--- End quote ---
And it does works on my DAP. But when I wrote this in the Theme Editor it doesn't work.

Bieber:

--- Quote from: yzflcyq on July 17, 2010, 09:37:48 AM ---Found a bug:

--- Code: ---%V(4,242,232,20,2)%Vf(a4c0e4)
%s%ac%?id<%id%?iy<(%iy)>|%?iy<Year:%iy|--->>
--- End code ---

I wrote this in order to show like:

--- Quote ---Air OST(Year:2002)
--- End quote ---
And it does works on my DAP. But when I wrote this in the Theme Editor it doesn't work.

--- End quote ---

When the new parser is fully integrated in Rockbox this won't parse.  The problem is that you put parentheses around %iy without escaping them.  The correct way is like this

--- Code: ---%V(4,242,232,20,2)%Vf(a4c0e4)
%s%ac%?id<%id%?iy<%(%iy%)>|%?iy<Year:%iy|--->>

--- End code ---

DavidW:
I hope this is the right place for this...

How about adding a function that will convert an old theme to the new format?

Thanks for your hard work.

[Saint]:
DavidW

This is already possible, a pre-compiled executable is here:

skinupdater

The syntax is: skinupdater wps_name.wps wps_new_name.wps

Update your .wps .fms and .sbs files seperately



[St.]

mc2739:
Great work so far on the theme editor.  I have already used it to clean up a couple of my themes that had issues with viewport alignment.  I am looking forward to the finished project.

Some comments after testing themeeditor-r27559 (windows version)

1. FMS preview does not render SBS info

2. An SBS viewport that is conditional on current screen (%cs) and playmode (%mp) does not render properly.  For example, I have an SBS viewport set to display song info while the song is playing or paused and the screen is the menu screen.  It is set to display an empty viewport when the song is stopped or the screen switches away from the menu screen.  The current behavior of the theme editor displays this viewport properly when displaying the SBS preview, but when displaying the WPS preview it merges the contents displayed in the SBS with the contents of the WPS viewport that occupies the same screen coordinates.

3. The Export Project function creates a zip file with a top level directory with no name.  It also includes all font files which are used in the theme.  The standard practice for theme submission is to only include fonts which are not already included in the font pack. 

4. Export Project messages could be a little more descriptive:

* Warning: configfile not found (what configfile)
* Warning: themebase not found (what themebase)

Navigation

[0] Message Index

[#] Next page

[*] Previous page