Theme Editor Feedback

[glight]

Just wanted to chime in with a thank you for this. Fixing themes is way easier than going back and forth with the simulator line by line.

However, my first attempt at fixing a wps for the current build is still borked according to Rockbox...

[JdGordon]

its definitely line 17! I'll wager those 3 dots that it is anyway

[bluebrother]

its definitely line 17! I'll wager those 3 dots that it is anyway

You sure?

As for a more serious response: the lastest build of the Theme Editor is around a month old, and unless I'm mixing things up there have been changes to the WPS syntax / parser in the meanwhile.

[KiwiCam]

I've designed a theme that works well in the editor except that the animations I've designed won't show. They work as intended on the Clip itself and the Simulator, so I was wondering if someone could point out how to get it working properly in the Editor.

http://themes.rockbox.org/index.php?themeid=1425&target=sansaclipplus

The Trouble code is this:

Code: [Select]

%xl(S,s1.bmp,0,0)
%xl(T,s2.bmp,0,0)
%xl(U,s3.bmp,0,0)
%xl(X,s4.bmp,0,0)
%xl(W,s5.bmp,0,0)
#%Vl(g,0,0,120,19,6)
%t(3)%pb(0,0,-,19,-,slider,S,nofill,nobar);%t(3)%pb(0,0,-,19,-,slider,T,nofill,nobar);%t(3)%pb(0,0,-,19,-,slider,U,nofill,nobar);%t(3)%pb(0,0,-,19,-,slider,X,nofill,nobar);%t(3)%pb(0,0,-,19,-,slider,W,nofill,nobar)
#

[[Saint]]

It just.....wont.

You're using syntax that is far newer than the theme editor is aware of.
With the changes in the skin syntax of late, its really best to not use the theme editor.
You'll make a grand theme that works fine in the editor, with old and perhaps inefficient syntax, that doesn't work on device. Or try to edit a new theme with modern and efficient code, that doesn't works on the device and not at all in the theme editor

"Mr. Someone" needs to put some work into syncing the theme editor to current SVN...the problem is, those that know the syntax either (or a combination of all) have disappeared (albeit temporarily or from lack of time), quit Rockbox development, or run screaming from the implementation used in the theme editor...

On the upside, we *did* get a shiny new skin parser in core out of the theme editor development, so even if it is currently broken (the editor, not the parser)...that was a pretty big plus.


[Saint]

[KiwiCam]

I'd personally prefer to use the Simulator  .  But, the Simulator can do way more with themes than my Clip actual. The Editor, from when I tried it a few months ago, and am trying again now, seemed to be less tolerant of not so good code. What I like about the Editor, is that the changes seem to take effect immediately, whereas, on the Simulator, my fingers are doing the two-step, while I sleep. All those bloody key-presses and now that I've tried it again, I think I could get to liking it.

It's a good thing that I'm able to pause the Rugby. Go the All Blacks!

[[Saint]]

In theory, the sim and the device should behave exactly the same with regard to skins...if they don't, that would be a bug.

Can you clarify on the differences you see?


[Saint]

[KiwiCam]

Can you clarify on the differences you see?


[Saint]

Absolutely. I'll have to take some time to recall those I've noticed. But, I'll come back about it. Two that come to mind, are that the Sim allows the use of extra Bitmaps, or at least, more repeats of the stored images. Able to handle more combinations, and sequences. Probably the best way would be for me to find some examples. I'll dredge back through previous saves, or just try and replicate them.

I have a suggestion for a change to two of the plugins. Do I make those suggestions in the Features section?

Gawd. I'm so nervous about the game, I'm still watching the Anthem.