Support and General Use > Theming and Appearance Customization
Theme Editor Feedback
Bieber:
--- Quote from: mc2739 on July 26, 2010, 01:59:20 AM ---Great work so far on the theme editor. I have already used it to clean up a couple of my themes that had issues with viewport alignment. I am looking forward to the finished project.
Some comments after testing themeeditor-r27559 (windows version)
1. FMS preview does not render SBS info
2. An SBS viewport that is conditional on current screen (%cs) and playmode (%mp) does not render properly. For example, I have an SBS viewport set to display song info while the song is playing or paused and the screen is the menu screen. It is set to display an empty viewport when the song is stopped or the screen switches away from the menu screen. The current behavior of the theme editor displays this viewport properly when displaying the SBS preview, but when displaying the WPS preview it merges the contents displayed in the SBS with the contents of the WPS viewport that occupies the same screen coordinates.
--- End quote ---
Could you start a FlySpray bug page or otherwise contact me with the theme files that are causing these bugs for you? I have some suspicions as to what might be going wrong, but I'll need to be able to reproduce the issue the same way you're experiencing it to know for sure.
--- Quote ---3. The Export Project function creates a zip file with a top level directory with no name. It also includes all font files which are used in the theme. The standard practice for theme submission is to only include fonts which are not already included in the font pack.
--- End quote ---
Is it not standard practice to make the first directory in the zip file .rockbox? This is how I see all the themes on the themesite. As for the fonts, the only fonts you want to put in your project's fonts/ directory are ones that you want bundled with the theme. If you take a look at the "Render" tab of the preferences dialog, you'll see that there's an option for a directory to store fonts in and a button to download the font pack. Just pick somewhere you want to keep the font pack (mine is ~/rbthemes/.fontpack, just pick somewhere that won't get in your way), click the download button, and it will dl/extract the font pack in that directory (or you can just copy them over if you already have it). You'll be able to use those fonts in your themes without having to put them in the fonts/ directory, so they won't be included in the exported project
--- Quote ---4. Export Project messages could be a little more descriptive:
* Warning: configfile not found (what configfile)
* Warning: themebase not found (what themebase)
--- End quote ---
configfile and themebase are both internal settings that shouldn't be showing up there :( Could you show me the config file that gave you those warnings?
mc2739:
--- Quote from: Bieber on July 26, 2010, 05:36:56 PM ---Could you start a FlySpray bug page or otherwise contact me with the theme files that are causing these bugs for you?
--- End quote ---
I have a copy of the theme uploaded on jdgordan's BIG display code cleanup task here: http://www.rockbox.org/tracker/task/11470?getfile=22284
--- Quote ---Is it not standard practice to make the first directory in the zip file .rockbox?
--- End quote ---
The zip file that i get when exporting the project has a folder with no name at the top level and then the .rockbox folder within that one. I see this when opening the file with 7-zip. Extracting the zip file contents does give the expected results. See the attached screen shot.
--- Quote ---As for the fonts, the only fonts you want to put in your project's fonts/ directory are ones that you want bundled with the theme.
--- End quote ---
You are exactly correct on this one. I had set up the font pack location with an earlier version that I was looking at, but had not done so this time.
--- Quote ---configfile and themebase are both internal settings that shouldn't be showing up there :( Could you show me the config file that gave you those warnings?
--- End quote ---
See the theme linked above.
Bieber:
--- Quote from: mc2739 on July 26, 2010, 06:24:58 PM ---The zip file that i get when exporting the project has a folder with no name at the top level and then the .rockbox folder within that one. I see this when opening the file with 7-zip. Extracting the zip file contents does give the expected results. See the attached screen shot.
--- End quote ---
I can't reproduce this one, I'm going to have to take a look at with 7-zip on a Windows machine later. I'm pretty sure that my last couple revisions fixed all the other bugs you reported: if you get a chance, it would be nice to know if it worked out for you :)
mc2739:
SBS info does now render in the FMS preview and the configfile and themebase warnings on export are no longer displayed.
The SBS no longer merges the two lines on the WPS preview, but the line is no longer displayed on the SBS preview (%?cs on line 37 of the SBS file). Also, two additional lines which should prevent the the shuffle and repeat icons from displaying on the radio screen are not rendered properly (%?cs on lines 55 and 59 of the SBS file).
Bieber:
--- Quote from: mc2739 on July 31, 2010, 07:04:43 PM ---The SBS no longer merges the two lines on the WPS preview, but the line is no longer displayed on the SBS preview (%?cs on line 37 of the SBS file). Also, two additional lines which should prevent the the shuffle and repeat icons from displaying on the radio screen are not rendered properly (%?cs on lines 55 and 59 of the SBS file).
--- End quote ---
That one's not really a bug, just a less-than-intuitive feature ;) To get those things to render, you had to change the "Current Screen" setting in the "Misc." tab of the device options panel. I just committed an update that checks the file extension of documents when they're first loaded and changes the "Current Screen" setting to "WPS" for WPS documents, "FM Screen" for FMS documents, and "Menus" for SBS documents, so that should give you a better preview by default.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version