Display problems with clip+

[rokkon]

Hi, i have recently installed rockbox (r27243-100702) on my new Sansa clip+.
As mentioned above i'm having some troubles with the display, i.e. the screen seems to shifted to the right and the few 'overhanging' pixels are displayed at the very left side. sorry for the somehow stupid description, i hope you know what i mean anyways. Problem is there no matter what theme i choose...

thanks in advance.

[funman]

Please take a picture of the screen and upload it somewhere (or attach it to this thread)

My Clip+ works fine btw

[rokkon]

For the sake of visibility i just gimped it. Watch the statusbar and time elapsed/time total at the bottom.
This is just an example, the problem remains in all other screens, not just wps.

[funman]

Is that a screenshot (top picture) and not a real picture, which you shifted in gimp to give the bottom picture ?

Try to put your camera in macro mode, it makes better pictures (but might require a few tries)

Is the shifting constant ? (it is 2 pixels in your picture but it can't be a real picture)

About the clip+ (well all the clips in fact) screen, the LCD controller has an internal framebuffer of 64 lines which are 132 pixels wide, but the screen itself is only 128 pixels wide.

So if some pixels which should be on the right side are displayed on the left, there should be a 4 columns with empty pixels (we clear these 4 columns at initialization and never write them again).

Can you see these 4 empty columns ?

Also do you have a build environment to try potential patches if we identify a problem ?

P.S. if the problem happens in every screen then changing the theme will have no effect.
Also you might want to see if the 'lamp' plugin works alright (it should light every pixel)

Thanks

[rokkon]

The upper picture is in fact a screenshot of the 'literal' theme i took from the themes page. I took this image to produce the lower image which perfectly resembles what i see on the player. I included the original just for comparison. I'm sorry but for now it's not possible for me to take a picture of the actual screen due to the absence of a capable camera.

The shifting is constant and i'd say the last 2 rows of pixels (on the right side) are displayed on the left just like in the fake picture. It's a little hard to count pixels on the player screen though.

I cannnot see any emtpy colums and i'm a little confused where to find them? Again, the fake pic mimics the actual screen quite well.

Lamp plugin looks ok although i can't tell if anything is shifted because all colums are equal in that case.

Applying patches shouldn't be a problem...

Thanks.

[funman]

There is a 2 columns offset applied to the internal clip framebuffer, this patch removes it, does it fix your problem?

The offset has been present since the clipv1 driver was committed so I don't remember exactly why, but I assume to center the framebuffer on the screen (the 2 leftmost and the 2 rightmost columns are not displayed).

If this works please let me know I'll see if the Clip+ OF discriminates between 2 different controllers and decide to add this offset or not (I assume the OF works correctly?)

[rokkon]

I tried the patch and well, unfortunately it doesn't really fix the problem.

Something has changed anyhow. Whenever a new menu is opened the display is fine for about a second until the screen gets shifted again.

This is also constant and holds true for all menus.

EDIT: OF is working correctly

[AlexP]

Does the clip+ not support screenshots?  Or do the screenshots not show the issue?  If it does, enable screendump in the debug menu (in the system menu) then plug usb to get a screenshot.  No need for a camera then.

[Vague Rant]

Does the clip+ not support screenshots?

Just tested on my Clip+, screendumps work fine; I can't replicate the issue so can't say if it shows up in them or not.

[rokkon]

Screendump works but does not show the problem, it's only visible on the lcd.

[funman]

screendump copies the rockbox framebuffer so if the Clip+ LCD driver is buggy screendump will not show the issue.

rokkon, please try this patch, I had forgotten one offset, so the screen was still shifted during full updates

[rokkon]

Works fine

Thanks for fixing this in no time!

Will this move into the current build soon?

[funman]

Good to read that it works

It can not move to the current build as-is because (as expected) using this patch on my Clip+ shifts the display the other way around.

The 2 rightmost columns are empty though, also as expected if the framebuffer is 132 columns.

Can you stay around and test a patch which could work on all the Clip+ ?

[rokkon]

Sure no problem, i will help where i can

[funman]

Please try this, it works on my Clip+ and Clipv1.

The LCD type is detected with GPIO B3, it was already documented on SansaAMSHardwareMappings.

I assumed the framebuffer is 128 columns in your clip+, there could also be other differences but if it works it's alright

EDIT: I made a mistake and edited the patch (same URL) : the correct version has GPIOB_DIR &= ~(1<<3); in sansa-clip-plus.c