Recording Enhancements Pack

[simon142857]

Been lurking here for quite a while- thought I would finally dip into the discussion to most importantly offer thanks to Mmmm, Petur, and the entire Rockbox crew of Devs for this brilliant enhancement to my Iriver!
Yeah Baby!
I'm a live recording kook- from Gospel Churches to Rock concerts to Poetry readings. For a decade my MD and me were best buds!
Then I heard about Rockbox- got an Archos, and now the Iriver. These recording enhancements are a dream come true!

OK! Now with that in mind, I'm posting to echo Dr. Pheels dilemma. My h120 is also not responding to the clip light function. I'm using the latest build from Mmmm.
I read the mature, wise admonition from Petur to be patient- and that all this would settle out eventually in the CVS.

But I'm a BRAT!
cliplight cliplight cliplight!
 :'( Wah! :'(

 

[whatboutbob]

dr.pheel & simon142857:  I've not tested the backlight function in a while, but my post back a couple of pages may explain the issues you're having:

Something worth mentioning on the clipping indicator though...its not an exact tool...hence neither is the cliplight.  It is possible to clip without triggering the indicator.  The issues are at least twofold...but I'm running off memory here, which is unreliable at best.  I believe clipping needs to exist over two samples before its triggered (eg one loud clap won't trigger it).  Apparently it can also get false positives, and just not fire other times.  In other words, don't put complete faith in it.

So in short, a clap will not trigger the backlight, regardless of whether it clips.  Extended clipping will trigger the backlight...scream into the mics...see what happens. Warn your neighbours first maybe...you don't want cops turning up at your door wondering who's being murdered. 

[ericzang]

For the H300 series, is it ok to load the entire enhancements build, or is it necessary to load the general H300 build then patch it with the enhancement patch? Thanks.

[petur]

not all samples are being checked for clipping, which most probably causes this. I know where exactly in the code this is, just need some time to do it and also test how this affects performance...

[Mmmm]

hey Mmmm, in your build...whenever i click into the browse themes, it auto-selects the first theme and exits the theme menu. the workaround i use is to hold the up or down while it's entering that menu. not a major issue but not sure why it's doing that. only that menu too it seems. i can access the others fine.

That also happened me before (but with the WPS menu), but I noticed that things work as they should if you use <right> instead of <click>. Just a temporary workaround though.

Ahhh right mlind, if that is the case then I would say that it is something to do with the joyclick patch! I always use 'right' to select, this is why I couldn't reproduce the bug!  (this is assuming that you and  renho3k are both using the build in my sig and not the changeable fonts version).

There should be a check to make sure that that particular function only  works in the filebrowser...I'll see what I can do!

For the H300 series, is it ok to load the entire enhancements build, or is it necessary to load the general H300 build then patch it with the enhancement patch? Thanks.

Neither build will work on the h3xx but the patches will work fine!
I did do a build for h3xx which I havent updated for a while, but it will still work HERE IT IS

My h120 is not responding to the clip light function.

What petur and whataboutbob said.

....and I have also noticed Petur, that the version you have committed only works while the unit is actually recording, whereas mine worked at all times in the recording screen!
It is the fix you made so that it compiled for all units. Your condition checks for recording whereas mine just checked that no file was being played (and so disabled the function in the WPS!)

[Metrophage]

Any chance that one of you folks might be so kind as to send to me a zipped copy of a working bootloader for this? I have spent hours looking for the "normal" Linux patching tools for my mac but not gotten it working yet. No windoze box here so as of yet no Rockbox for me. I will still try to collect the proper tools and wrap them into a patching application for other mac users, but this will likely take me a little while.

I bought my h120 recently because of its codec support and recording capabilities. This version from Mmmm addresses most of my wants, so I am really looking forward to this. I am trying to make some basic microphones from Panasonic electret capsules for recording various ambient location sounds - something I have always wanted to do.

Thanks much!
CJ

[petur]

....and I have also noticed Petur, that the version you have committed only works while the unit is actually recording, whereas mine worked at all times in the recording screen!
It is the fix you made so that it compiled for all units. Your condition checks for recording whereas mine just checked that no file was being played (and so disabled the function in the WPS!)

I know.
When changing, I thought about this for some time, and couldn't come up with a reason to have this on unless you're actually recording...

Tell me what the reason is and I'll change it

[Mmmm]

....and I have also noticed Petur, that the version you have committed only works while the unit is actually recording, whereas mine worked at all times in the recording screen!
It is the fix you made so that it compiled for all units. Your condition checks for recording whereas mine just checked that no file was being played (and so disabled the function in the WPS!)

I know.
When changing, I thought about this for some time, and couldn't come up with a reason to have this on unless you're actually recording...

Tell me what the reason is and I'll change it

You're in a dark room waiting for a concert to start.....you've got your recorder alll ready to go but, as yet, you are not really sure whether your levels are right.... before the gig begins, there is a quick warmup by the band It's too dark to see whether its clipping or not and you don't want to start recording until they start the set properly.. cor, you think...a cliplight would be really handy now! 

[paulheu]

Here's another one:

I use my iRiver to record live from the board, I do not want the display on all the time..

If I get a bit too enthusiastic while setting up I will see the LCD flash if the level gets too hot..

VERY USEFUL INDEED

[mlind]

Tell me what the reason is and I'll change it

–Because!!   

[petur]

3 against 1, I surrender

[AGI]

4 against 1

[whatboutbob]

5 against 1...now we're just ganging up on him.

[renho3k]

7 vs 1...
(gerbil in sleeping in my pocket woke up just to vote in this poll too)

[petur]

all right all right... code changed and partially tested, will commit tonight if possibe (that is: if I get the time and test the other platforms)

then I'll fix the peakmeter missing clipped samples as well, ok?