Recording Enhancements Pack

[Mmmm]

There's missing an adjustment in apps/gui/statusbar.c on which breaks compiling on RTC targets

Code: [Select]

---  apps/gui/statusbar.c      2007-02-27 14:27:24.412249030 +0100
+++ apps/gui/statusbar.c        2007-02-27 14:23:54.851257558 +0100
@@ -155,7 +155,7 @@
 static void gui_statusbar_timer(struct screen * display, int dy, int hr, int mn, int sc);
 #endif
 #ifdef CONFIG_RTC
-static void gui_statusbar_time(struct screen * display, int hour, int minute);
+static void gui_statusbar_time(struct screen * display, int hour, int minute, bool timer_display);
 #endif
 #endif

Oops, I'll fix that tonight...I only tested compiling for H140 which doesn't have rtc so I missed that one.

EDIT: Ok, it's fixed now.....

[Wolf]

Martin,
Somehow I'm still getting your REP release from the 17th from your signature...
Thx for keeping this wonderfull add-on updated, Wolf.

[TaperChuck]

So, the REP build now incorporates the RTC patch?

[Febs]

I believe that the RTC patch was committed to SVN today, so it is now part of the official builds.

[Mmmm]

Martin,
Somehow I'm still getting your REP release from the 17th from your signature...
Thx for keeping this wonderfull add-on updated, Wolf.

Hmm, sorry about that.... Should be th latest build now (still only the REP), and I've updated the patch to work with the RTC mod.

[Wolf]

Working now, thx! Wolf

[jplumey]

Weird interference from the hard drive when recording.

When I hit the record button the hard drive spins up for about 5 seconds and in the audio of the recording I hear some loud interference that comes from the hard drive. When the hard drive spins down, the interference goes away and the recording sounds great. I am using the latest build of the REP (which is amazing, btw).

Any thoughts?

[jplumey]

Never mind.. I did another search and found out that it's the just the internal mic. Thanks.

[Wolf]

Trying to compile with the REP for the first time (SVN went ok, wooohooo!) I noticed that the current REP patch fails on apps/sound_menu.c (which is now located at apps/menus/sound_menu.c).

Even simple changing the file new location didn't work. Is this simple to solve or consequence of the menus improvements?

Thx, Wolf.

--------------------------
|Index: apps/sound_menu.c
|===================================================================
|--- apps/sound_menu.c  (revision 12521)
|+++ apps/sound_menu.c  (working copy)
--------------------------
File to patch: apps/menus/sound_menu.c
patching file apps/menus/sound_menu.c
Hunk #1 FAILED at 41.
Hunk #2 succeeded at 80 with fuzz 2 (offset -3 lines).
Hunk #3 FAILED at 355.
Hunk #4 FAILED at 520.
Hunk #5 FAILED at 571.
Hunk #6 FAILED at 729.
Hunk #7 FAILED at 879.
Hunk #8 FAILED at 1062.
Hunk #9 FAILED at 1074.
8 out of 9 hunks FAILED -- saving rejects to file apps/menus/sound_menu.c.rej

[redwood]

Trying to compile with the REP for the first time (SVN went ok, wooohooo!) I noticed that the current REP patch fails on apps/sound_menu.c (which is now located at apps/menus/sound_menu.c).

Even simple changing the file new location didn't work. Is this simple to solve or consequence of the menus improvements?

Wolf - I'd say it's due to the menu changes, yes.

Mmmm - do you know if the menu changes that would affect the REP have been finished? Looks that way to me but I am not an authority on code matters. Any idea when you might update?

thanks

jp

[Rincewind]

It seems to me that there are no more great changes to come for the recording menus and settings. Whoever updates the REP, I made a new Rec Button Config patch, it works again and now has insert options in file browser. FS #5555

[Mmmm]

Yeah, no more big changes now..... The changes are pretty big so not an easy fix(for a non coder anyway) I'm afraid. I've fixed up the countdown timer (which should be the hardest part) but haven't started on the rest of the REP yet. But I will... Just need a little spare time
I'll attempt Rincewinds new patch too while I'm at it...

[BayTaper]

I know you guys probably hate the one-off feature requests, so apologies in advance, but I thought I'd mention something related to AGC functionality. My comment specifically relates to safety AGC, but I think it is probably relevant for all AGC modes. What would be great is a way to "link" or "unlink" the left/right channels so the AGC works on both channels together.

Here's an example of why this would be helpful. You're stealthing in safety agc mode. You get a screamer to your right who causes the right channel to clip harder than the left (or the left doesn't clip at all), the agc comes in to help things out going forward but ends up lower the right channel more than the left. Now the rest of the show gets recorded at significantly different levels between the two channels. If you could link the channels, the screamer on the right would cause safety agc to lower both channels (left/right) the same amount such that the left won't clip at that same loudness scream, but both levels of both channels are still set the same going foward.

Does that make sense? That's just one example, you could easily make other examples not related to a screamer or clapper that just come from the music, but where you'd want the levels to stay linked across L/R channels. It's kind of the same reason why the level adjustments first work on both channels at the same time, and then you have to press down again if you want to adjust levels independently for each channel (this is how setting levels already works, and it kind of exemplifies the same reasons why you might want AGC mode to operate in a similar way. I could see it being an option under the AGC menu -- to link channels or not.

Anyway, just a thought, and thanks again for the development efforts, rockbox is an invaluable tool no doubt...

[mlind]

?
Do you really mean that now the AGC really does change the gain independently for left and right?
When would you actually want that?

[petur]

yes it does that if there is a severe unbalance between L and R... didn't know this was also active in safety mode... must check