Recording Enhancements Pack

[Mmmm]

I havn't looked at the RTC patch because I'm not going anywhere near the innards of my player if I can help it, but the question is really whether it breaks un-modded players, if so It's definitely not going to get included. If not, I'll think about it!  

[Bedlore]

I encourage you install this mod, I didn't take any precautions really. I didn't earth my soldering iron, didn't disconnect the battery, accidentally soldered together the pins of an existing IC yet it survied and the mod works brilliantly.  

I accept that if it breaks un-modded units then it definitely must not be included, but I would be keen to help you decide if that is or isn't the case.

Thanks for considering it, in my opinion this mod is very significant and contributes what was a major lack to the H1xx units when it comes to recording.

Let me know how I can help

[Llorean]

Are any of the patches in this build still actively being developed toward inclusion? I've left this build alone for quite some time because it was a focus of several core developers, but by this point I haven't seen many recording enhancements move from this build to CVS, and it's reaching a point where I'm considering moving this thread to the unsupported builds forum before someone starts calling "hypocrisy" on me.

I'd really like to also know if any of the patches in this build are flat out likely to never be included in CVS.

[roolku]

but the question is really whether it breaks un-modded players, if so It's definitely not going to get included. If not, I'll think about it!  

Depends what you mean by "break". It will work, but timestamps and filenames will be set to invalid times rather than use the workarounds for RTC-less players. So I wouldn't recommend using it for players without the mod.

I guess that means two REP builds, one with RTC patch, one without.

[LinusN]

I guess that means two REP builds, one with RTC patch, one without.

Perhaps we should consider autodetecting the presence of an RTC...

[TaperChuck]

I guess that means two REP builds, one with RTC patch, one without.

Perhaps we should consider autodetecting the presence of an RTC...

Great idea!

Since I did the mod, now I'm worried my build will become obsolete, because I think the patching is MUCH harder to do than soldering in the chip.

[Rincewind]

Are any of the patches in this build still actively being developed toward inclusion? I've left this build alone for quite some time because it was a focus of several core developers, but by this point I haven't seen many recording enhancements move from this build to CVS, and it's reaching a point where I'm considering moving this thread to the unsupported builds forum before someone starts calling "hypocrisy" on me.

I'd really like to also know if any of the patches in this build are flat out likely to never be included in CVS.

Well, I would like to see an inclusion of my record button patch and there seems to be at least a consensus that someting should be done about the record button, but not what exactly. If I come around to code the special options for file browser (insert stuff mostly) then I would consider the patch ready for inclusion, and I am willing to change the functionality of the patch if that helps inclusion.
To sum it up: my patch is still actively under development, I'm just waiting for the menu recoding to finish until I work on it again.

[redwood]

I think Rincewind's patch is a must, it should definitely be included when he's ready to update it with the new menu settings.

thanks

[Rincewind]

Since I did the mod, now I'm worried my build will become obsolete, because I think the patching is MUCH harder to do than soldering in the chip.

Well, it is the other way round for me
I don't want to give my 10€ soldering iron a chance to brick my player.

And if you get the patching right once, then it doesn't get any harder to keep it up to date, and making your own builds is just typing 3 commands and getting a coffee inbetween then.

[roolku]

I guess that means two REP builds, one with RTC patch, one without.

Perhaps we should consider autodetecting the presence of an RTC...

I have added a preliminary version of the rtc patch with autodetection to flyspray http://www.rockbox.org/tracker/task/6419 . Let me know what you think.

There is a test build with the REP included here: http://roolku.pwp.blueyonder.co.uk/rockbox_rep_rtc_r12213.zip . I would appreciate some feedback.

EDIT: fixed link

[TaperChuck]

http://roolku.pwp.blueyon...ockbox_rep_rtc_r12186.zip

I used this version after I did the hardware portion of the RTC mod. So far it is working fine.

[roolku]

I have added a preliminary version of the rtc patch with autodetection to flyspray http://www.rockbox.org/tracker/task/6419 . Let me know what you think.

There is a test build with the REP included here: http://roolku.pwp.blueyonder.co.uk/rockbox_rep_rtc_r12186.zip . I would appreciate some feedback.

Sorry I got the link to the compiled version wrong. The version with MOD auto detection is:  http://roolku.pwp.blueyonder.co.uk/rockbox_rep_rtc_r12213.zip

[TaperChuck]

That's awesome roolku! Auto-detect, that should help get it added into a regular build.

As far as the RTC mod goes, soldering was the easy part. Getting the code patched into the REP was the difficult part. I know I will fall behind in getting the new builds of the REP because of the hassle of having to patch the code each time, if it isn't added into the regular build.

[norbusan]

Rediff for current svn

[attachment deleted by admin, too old]

[paulheu]

REP is (seriously) broken against current SVN changes.. Maybe if I have some time I'll look into it this weekend..