Recording Enhancements Pack

[paulheu]

I believe I got the sync right.. here's my diff patch

[norbusan]

Hi Paul!

Thanks a lot. BTW: Did you update some of the other patches, too? I have asked on the tracker for some of them in the meantime.

Thanks again for the great work

Norbert

[paulheu]

I have updated all patches I use which had changes to settings.c..

[norbusan]

But you probably don't have split out versions of these patches? Well, I will take a look at your and try to update the single patches.

Thanks and bye

Norbert

[Rincewind]

I'm going to wait with the update of my record button config patch until the menu rework is complete. Otherwise I would have to update everything again in a week or two.

[TaperChuck]

I find that I use the balance indicator a lot to determine how centered my recordings are. I don't use the histogram at all. I'm wondering if the balance indicator is configurable or if it can be made configurable. I would like it to spead across the whole bottom of the screen, like the histogram does. I like that I can eliminate the histogram by holding the bottom right button for a couple of seconds.

[paulheu]

Even better, you can set the histogram to not show at all..

[Bedlore]

Can someone tell me if the RTCModH1x0 patch ( http://www.rockbox.org/twiki/bin/view/Main/RTCModH1x0 ) is compatible or even better, included in REP? Is there any chance of getting this permanently included in REP, that would be excellent if possible since REP and the iH1xx series RTC mod goes hand in hand.

I've never used a patch before so am not sure how to go about it.  Any advice would be appreciated.   Thanks  

[redwood]

Hey

I was doing a build off today's svn and got a couple of hunk failures when patching the REP:

 patching file apps/user_action.c
patching file apps/user_action.h
patching file apps/SOURCES
Hunk #1 succeeded at 18 with fuzz 1.
patching file apps/action.h
patching file apps/settings.c
Hunk #1 succeeded at 724 with fuzz 2 (offset 19 lines).
Hunk #2 succeeded at 1123 (offset -1027 lines).
patching file apps/settings.h
Hunk #1 succeeded at 325 (offset 139 lines).
Hunk #2 succeeded at 420 (offset 133 lines).
Hunk #3 FAILED at 692.
Hunk #4 FAILED at 718.
2 out of 4 hunks FAILED -- saving rejects to file apps/settings.h.rej
patching file apps/settings_menu.c
Hunk #1 succeeded at 2206 (offset 20 lines).
Hunk #2 succeeded at 2296 (offset 20 lines).
patching file apps/sound_menu.c
patching file apps/tree.c
Hunk #3 succeeded at 783 (offset 2 lines).
patching file apps/gui/gwps.c
patching file apps/gui/statusbar.c
patching file apps/gui/statusbar.h
patching file apps/keymaps/keymap-h1x0_h3x0.c
patching file apps/keymaps/keymap-x5.c
patching file apps/lang/english.lang
Hunk #1 succeeded at 2716 (offset 3 lines).
Hunk #2 succeeded at 8598 (offset 3 lines).
Hunk #3 succeeded at 9902 (offset 3 lines).
Hunk #4 succeeded at 9955 (offset 3 lines).
Hunk #5 succeeded at 10271 (offset 3 lines).
patching file apps/recorder/icons.c
patching file apps/recorder/icons.h
patching file apps/recorder/peakmeter.c
patching file apps/recorder/peakmeter.h
patching file apps/recorder/recording.c
patching file apps/recorder/recording.h

Is this a problem with settings.h or the REP? I'm a novice at compiling so any assistance is appreciated.

jp

[Rincewind]

Which Patch did you use?
If you used the original REP from the first post in this thread, then it failed because the REP is out of date at the moment (that's because there was a large change about settings in SVN recently).
paulheu made an update of the REP, see a few posts above me.

If you used paulheu's patch then either this patch is out of date now, too, or something else was wrong. You can have a look at settings.h.rej and try to understand what failed.

[redwood]

Which Patch did you use?
If you used the original REP from the first post in this thread, then it failed because the REP is out of date at the moment (that's because there was a large change about settings in SVN recently).
paulheu made an update of the REP, see a few posts above me.

Yes I used the original patch my mmmm, thanks for the info. I see that Paul's patch is a diff patch and I'm a little unclear how to proceed with it, do I just patch the whole SVN build it the same way as the other patch, or do I patch the REP patch itself?

You can have a look at settings.h.rej and try to understand what failed.

I did take a look at it and I didn't quite understand what the problem was - I'm still learning this stuff.

thanks!

[paulheu]

A diff or patch is (sortof) the same thing ..

A diff is the DIFFerence between the original and the patched code..

[Bedlore]

Howdy, I'd like to request that the REP releases recieve support for roolku's RTC mod for the H1xx please.  It really does go hand in hand with getting the most out of recording with Rockbox and I believe more and more H2xx owners will be doing this.
Roolku rolled one release as a once off here:
http://forums.rockbox.org/index.php?topic=7605.msg66916#msg66916

I'd like to hear others opinion on this.

Thanks
Bedlore

[Rincewind]

well, the code for the RTC really only makes sense if you have made the hardware-mod.
And I don't think that most users of the REP want to mod their player just to use the REP...

[TaperChuck]

I just did the RTC mod and was unable to patch the REP version myself. I would like to see the RTC patch incorporated into the regular REP build.