Recording Enhancements Pack

[paulheu]

The synced Histogram patch and the Peakmeter Margins and Height patch do not sit well together right now..

[old45]

Are any of the features of the recording enhancement pack included in the daily builds or are they confined to the CVS files?

[Llorean]

Daily builds are JUST CVS builds that are made once per day and backed up.

[Jillorious]

Daily builds are JUST CVS builds that are made once per day and backed up.

Then why does the manual say that the daily builds are more prone to bugs than the CVS builds?

[Llorean]

Imagine this scenario:

Bob the coder introduces an accidental major bug. He fixes it 10 minutes later.

If the users are downloading CVS builds, there is a 10 minute period during which they can end up with this major bug. If that build lands on the crossover where the daily is made, any users downloading daily builds will be stuck with this bug. It won't be gone from the daily for 24 hours, even though it was fixed 10 minutes later.

In most cases, if a bug is fairly obvious, it gets fixed fairly quickly. Unfortunately users of daily builds with obvious bugs won't get the fixes unless they update to a CVS build. Therefor it's better that all users only use CVS builds, so that as of the time of downloading, they're getting the most recent bug fixes, instead of problems that were fixed as much as 23 hours prior.

[Chill]

So do we really need daily builds at all then?

[Llorean]

Yes, primarily for archival purposes as far as I know. The daily builds are kept for a month, so that should some major, hard to fix bug creep in, users can use a slightly older daily until it's fixed.

[Rincewind]

when I started using rockbox (about the same time last year) it was said, that the daily builds are more stable than the bleeding edge, because devs would take care not to submit major stuff right before a day break. I don't know if this really was (and is) the case.

The point is, if you watch the cvs log like a hawk, then it is better to download a bleeding edge and download another one if an important fix is out a few minutes later. But if you just want to download a build and go on holidays it would be better to take a daily build.

[Llorean]

If you want to take a build on holiday, you shouldn't pick a build you haven't tested yet. A week before the holiday you should stop updating unless you're sure a build is solid.

These days, many devs aren't even certain when the daily builds are made, so while yes some major changes may wait until after the daily build, that doesn't do anything for "unintended consequences" or developers who don't know when it'll happen.

[redwood]

Personally I find the histogram/balance unnecessary, and when using a larger font it ends up overwriting it anyway. Is there a way to either defeat the histogram/balance meter or set smaller fonts in the WRS only?

thanks for all the great work

jp

It overwrites it? really?? It's supposed to change to the default font in that case....Damn!...

Which font do you use?

I'm using nimbus-12

jp

[Mmmm]

Hmmm just tested it and when I use nimbus-12 I get the system font in the recording screen!
But you get nimbus 12 in the recording screen overwriting the histogram? Weird

I'm going to put a new patch/build up soon so when I do try that... I'll tell you when

[Mmmm]

Aha... I think I may have found the problem Redwood...
I'll put a new build up soon...which will hopefully fix it  

[redwood]

Cool! What was it? (I won't pretend to understand but am starting to study some C++ so maybe i could learn something)

jp

[Mmmm]

All it was was that the font check was done outside the main recording screen loop which meant that if you go into the screen with a certain font (say nimbus12) and you have a mic or digital source then everything will be fine, but if you then change to line source the font wouldnt be rechecked and so you would get an overlap of the histogram. I have simply moved the font check into the loop and made it so that it is only checked when  last_source !=source (ie only when the source has changed), simple!

well, I hope that was your problem anyway...it was the only way I could reproduce it!

I should be able to post the new code today sometime.

PS. Rockbox is coded in C, not C++  

[Mmmm]

Ok then..here we go.. A new version at last

Unfortunately we have lost rincewinds record button patch as I was too lazy to update it and I think that he will do that sometime anyway... I'll add it when he does.

I have put in a patch that displays the samplerate and channels (mono/stereo) in the statusbar when in the recording screen.
This means that you can now see this info on any screen (main and remote) all the time.

It also means that we have more space on the main screen so bigger fonts are possible...although not that much bigger unfortunately...one extra line doesnt go far I'm afraid!

Input method                      Previous max fontsize          New max fontsize
Line In                                              10                        Â     11   ->No change really
Mic In                                                11                            12    ->some extra fonts become possible
Digital In                                           14                             17    ->WOW!

I did a bit of tweaking for the fonts patch too:
i) to get rid of the bug redwood noticed (now the font will change as soon as you change the input method)
ii) take into account the lack of AGC info for digital in (the reason for the large increase in max fontsize for digital in)

Post#1 for patches etc....