Recording Enhancements Pack

[petur]

note: AGC has been committed to CVS 

[BayTaper]

Congrats!

[petur]

Mmmm, I have closed http://www.rockbox.org/tracker/task/4748, I count on you to add the rest of the REP that is commitworthy... Don't know if the histogram should get committed.

I'll be having less time to work on rockbox for about a month :/

[Mmmm]

Mmmm, I have closed http://www.rockbox.org/tracker/task/4748, I count on you to add the rest of the REP that is commitworthy... Don't know if the histogram should get committed.

I'll be having less time to work on rockbox for about a month :/

Wow...you've finally got around to committing the AGC...Fantasic
That has pretty much killed the REP off I think, apart from the histogram (I wouldn't submit the rest). What are you unsure of about the histogram? Is it because it really has no use other than just eye candy, or the way it is coded?

I'll have a look at that some time (although I'm still nowhere near my Dev-Environment  :'( - ahh well, there's more to life than coding eh? ).

[petur]

What are you unsure of about the histogram? Is it because it really has no use other than just eye candy, or the way it is coded?

The first... I see not much use for it, so maybe somebody can convince me?

[paulheu]

Mmmm, I do hope you're releasing a (final) patch with whatever is left..

[Mmmm]

What are you unsure of about the histogram? Is it because it really has no use other than just eye candy, or the way it is coded?

The first... I see not much use for it, so maybe somebody can convince me?

I agree..not a lot of point really, but it looks gorgeous!
I suppose you can tell if you had a clip recently as you have a history of input levels.
erm.... You can get an exact balance using the balance-ometer.
But I must say, I have never used this while recording and can't see myself ever needing to.
......But it looks fantastic.

Has anyone actually used this feature?

Mmmm, I do hope you're releasing a (final) patch with whatever is left..

Yes, I probably will when I get around to it

[petur]

I agree..not a lot of point really, but it looks gorgeous!
I suppose you can tell if you had a clip recently as you have a history of input levels.
erm.... You can get an exact balance using the balance-ometer.
But I must say, I have never used this while recording and can't see myself ever needing to.
......But it looks fantastic.

Has anyone actually used this feature?

No I haven't... maybe I should and get impressed
But no time here now :/

[Davide-NYC]

CONGRATS on the Commit!!!     

My opinion: The histogram is purely eye candy.
But the battery, disk and balance meters are very useful.
They don't need to be graphically represented.
A single line of formatted text would be just fine.
But graphics are nice... 

[Rincewind]

Mmmm, I do hope you're releasing a (final) patch with whatever is left..

One thing that is left, my record button patch, needs a major rework now that the whole button handling is changed completely. I try to update it in the next time.

[redwood]

Personally I find the histogram/balance unnecessary, and when using a larger font it ends up overwriting it anyway. Is there a way to either defeat the histogram/balance meter or set smaller fonts in the WRS only?

thanks for all the great work

jp

[Mmmm]

Personally I find the histogram/balance unnecessary, and when using a larger font it ends up overwriting it anyway. Is there a way to either defeat the histogram/balance meter or set smaller fonts in the WRS only?

thanks for all the great work

jp

It overwrites it? really?? It's supposed to change to the default font in that case....Damn!...

Which font do you use?

[paulheu]

Mmmm, I do hope you're releasing a (final) patch with whatever is left..

Yes, I probably will when I get around to it
[/quote]

From what I figure all that is left now is the fonts and histogram patch. The recording button patch has to be rewritten anyway. Maybe you could post an updated histogram patch to the patch tracker and add the fonts stuff as a separate patch. That would more or less keep everything nice and tidy and maybe have the fonts patch also committed shortly..

[paulheu]

OK.. so I actually managed to sync the (older) histogram patch against CVS..

check the tracker


I don't know if anything changed between the previous patch on the tracker and the one used in the REP, but if not it appears this is one less part of REP to update

Now for the fonts patch..

[Mmmm]

OK.. so I actually managed to sync the (older) histogram patch against CVS..

check the tracker


I don't know if anything changed between the previous patch on the tracker and the one used in the REP, but if not it appears this is one less part of REP to update

Now for the fonts patch..

Good work...I think you'll find the fonts a little more tricky though
But you can't beat a good challenge eh?