Recording Enhancements Pack

[Mmmm]

Have you managed to commit all of the REP components to CVS yet Mmmm? I'm holding off from using the current CVS untill things like AGC/Histogram etc are commited, but am really looking forward to get to try out the other new CVS features since I haven't updated since April.

I've done everything except fonts, AGC and histogram I'm afraid...Petur said the AGC isn't useable on all targets and so needs some looking into... Maybe i'll look into it..... I sort of keep getting side tracked!

[ALJ]

I can only affirm that the AGC is something that is sought after, and would be highly appreciated if it'd be included anywhichway and how !?!?

[Davide-NYC]

I have to re-iterate and agree with ALJ... AGC is a fantastic feature that I consider invaluable.
But it should be a Rockbox feature and not just a "RockRiver" feature.

I for one am willing to wait (or use your REP build from 20060705) until the code is portable to mutiple targets (people with iAudio units will be interested for sure)

To anyone who needs AGC right now you can just use Mmmm's R.E.P. build from here
http://homepage.ntlworld.com/martin.scarratt/Rockbox/rockbox.zip
or Pilot000's build from here
http://homepage.sunrise.ch/mysunrise/remartinelli/rockboxH120.zip

[Techy_Bloke]

G'day,

through the weekend i did some line in recording...

for a 3hrs 22min 9sec uncompressed wave file it is 1.99gb 

and then it gets auto split and starts 002...

quality is ausome just make sure u set your input levels properly.... bit before 0db...

Battery was on 15hrs - nearly full  - recorded non stop  for  7hrs 57 and 44secs and then had 1hr of battery left on it...  and died during playback

[Mmmm]

I have finally got around to doing it (and it was no small job - I did a really good job of breaking it! )

Now post#1 has all the updated files/builds.

[paulheu]

Thanks! I started doing it myself, but as you said it was quite broken ;^)

I have a new experimental build up for iRiver H3x0. check here for more info..

[Davide-NYC]

Hello Mmmm,

I was wondering if you could also upload a zip of the source of your REP builds for H120 targets.
That way I could include the 300remotekeys patch and the disktidy patch.
I have very little coding experience but would like to attempt to maintain a build that is essentially your REP build plus these two useful patches.

Out of curiosity, what is stopping AGC and Disktidy from being commited to CVS?

Davide-NYC

[Mmmm]

Hello Mmmm,

I was wondering if you could also upload a zip of the source of your REP builds for H120 targets.
That way I could include the 300remotekeys patch and the disktidy patch.

The patch for the REP is in post#1, that is all you need!

Out of curiosity, what is stopping AGC and Disktidy from being commited to CVS?

AGC needs to be made more friendly to other targets and I have no idea what disk tidy is!

[Scimmia]

I have no idea what disk tidy is!

Disktidy is a plugin that gets rid of the crap that operating systems put on your drive when you connect it as a UMS drive.

http://www.rockbox.org/tracker/task/2596

[petur]

Mmmm, can you compare the agc patch (in the tracker) with the state of your code? I've made it compatible with CVS again but am unsure if we followed the same way.

[Mmmm]

Mmmm, can you compare the agc patch (in the tracker) with the state of your code? I've made it compatible with CVS again but am unsure if we followed the same way.

 I think that the only thing I changed is how the AGC status is displayed (so that it is always directly below the gain setting) using the int line variable which is either 5 6 or 7 depending on the input (dig/mic/line as you have different no.s of lines displayed)). I also fixed the display for digital when pressing down as you got a load of blank stages before you reached the AGC status before. Apart from that I'm pretty sure it is the same as the original (apart from a few tweaks to make it work with the fonts and histogram patches).
I'll have a look at yours later

[petur]

I'll have a look at yours later

Fine. I'm looking at making it compatible with all targets that can record. Just checking stuff and fixing some hard coded assumptions into the correct variables...

[Mmmm]

Ok, I've had a look and digital mode doesn't work properly on yours (which I suppose is to be expected since you have an H3xx, so you're forgiven )

So I could add in the changes I made to get this working properly if you like, have you got a more up to date patch with any recent changes to the 'hard coded assumptions'?

[Mmmm]

OK Petur, If you are still monkeying around with that AGC patch the following will fix the Digital in recording screen (just in case you don't want to think about it )
Hope it makes sense to you!

around 510 have this as the cursor position definitions

Code: [Select]

#ifdef HAVE_AGC
    if (global_settings.rec_source == SOURCE_MIC)
    {
        if(cursor == 2)
            cursor = 4;
        else if(cursor == 3)
            cursor = 1;
    }
#ifdef HAVE_SPDIF_IN
    else if (global_settings.rec_source == SOURCE_SPDIF)
    {
        if(cursor == 1)
            cursor = 4;
        else if(cursor == 3)
            cursor = 0;
    }
#endif
    max_cursor = 5;
#else
    switch(global_settings.rec_source)
    {
    case SOURCE_MIC:
        max_cursor = 1;
        break;
    case SOURCE_LINE:
        max_cursor = 3;
        break;
    default:
        max_cursor = 0;
        break;
    }
#endif /* HAVE_AGC */

around line 1430 put this in to define placement of the AGC info

Code: [Select]

        if (global_settings.rec_source == SOURCE_LINE)
            line = 5;
        else if (global_settings.rec_source == SOURCE_MIC)
            line = 4;
#ifdef HAVE_SPDIF_IN
        else if (global_settings.rec_source == SOURCE_SPDIF)
            line = 3;
#endif

get rid of this around 1470

Code: [Select]

line = (global_settings.rec_source == SOURCE_MIC)? 4 : 5;

around line 1560 replace this:

Code: [Select]

#ifdef HAVE_AGC
            line = (global_settings.rec_source == SOURCE_MIC)? 5 : 6;
#else
            line = (global_settings.rec_source == SOURCE_MIC)? 4 : 5;
#endif
             for(i = 0; i < screen_update; i++)
                screens[i].puts(0, filename_offset[i] + PM_HEIGHT + line, buf);

With this:

Code: [Select]

            for(i = 0; i < screen_update; i++)
#ifdef HAVE_AGC
                screens[i].puts(0, filename_offset[i] + PM_HEIGHT + line + 1, buf);
#else
                screens[i].puts(0, filename_offset[i] + PM_HEIGHT + line, buf);
#endif

I also think that the remote display needs looking into as it goes off the bottom of the screen at times.... Something like the last line on the remote always changes into the next line (a bit like the agc info part).

[Techy_Bloke]

is there anyway of making just the recording screen text heaps massive instead of having it really small so its all easier to read

and also a bigger and labeled DB meter

and prehaps scrolling input waveform ??